From b280449969c5af0fe31eee1c8139e0995e54892f Mon Sep 17 00:00:00 2001
From: Jonathan Leroy <jonathan@inikup.com>
Date: Tue, 27 Oct 2020 11:25:55 +0100
Subject: [PATCH] Add record targets normalizaltion

---
 octodns/provider/gandi.py                                | 8 ++++++++
 .../{gandi-default-zone.json => gandi-records.json}      | 9 +++++++++
 tests/test_octodns_provider_gandi.py                     | 8 ++++----
 3 files changed, 21 insertions(+), 4 deletions(-)
 rename tests/fixtures/{gandi-default-zone.json => gandi-records.json} (92%)

diff --git a/octodns/provider/gandi.py b/octodns/provider/gandi.py
index 1f89a80..dcc222d 100644
--- a/octodns/provider/gandi.py
+++ b/octodns/provider/gandi.py
@@ -87,6 +87,14 @@ class GandiClient(object):
             if record['rrset_name'] == '@':
                 record['rrset_name'] = ''
 
+            # Change relative targets to absolute ones.
+            if record['rrset_type'] in ['ALIAS', 'CNAME', 'DNAME', 'MX',
+                                        'NS', 'SRV']:
+                for i, value in enumerate(record['rrset_values']):
+                    if not value.endswith('.'):
+                        record['rrset_values'][i] = '{}.{}.'.format(
+                            value, zone_name)
+
         return records
 
     def record_create(self, zone_name, data):
diff --git a/tests/fixtures/gandi-default-zone.json b/tests/fixtures/gandi-records.json
similarity index 92%
rename from tests/fixtures/gandi-default-zone.json
rename to tests/fixtures/gandi-records.json
index 9b07b8e..01d30f7 100644
--- a/tests/fixtures/gandi-default-zone.json
+++ b/tests/fixtures/gandi-records.json
@@ -98,5 +98,14 @@
     "rrset_values": [
       "32128 13 1 6823D9BB1B03DF714DD0EB163E20B341C96D18C0"
     ]
+  },
+  {
+    "rrset_type": "CNAME",
+    "rrset_ttl": 10800,
+    "rrset_name": "relative",
+    "rrset_href": "https://api.gandi.net/v5/livedns/domains/unit.tests/records/relative/CNAME",
+    "rrset_values": [
+      "target"
+    ]
   }
 ]
diff --git a/tests/test_octodns_provider_gandi.py b/tests/test_octodns_provider_gandi.py
index 7448666..a818919 100644
--- a/tests/test_octodns_provider_gandi.py
+++ b/tests/test_octodns_provider_gandi.py
@@ -126,19 +126,19 @@ class TestGandiProvider(TestCase):
         with requests_mock() as mock:
             base = 'https://api.gandi.net/v5/livedns/domains/unit.tests' \
                 '/records'
-            with open('tests/fixtures/gandi-default-zone.json') as fh:
+            with open('tests/fixtures/gandi-records.json') as fh:
                 mock.get(base, text=fh.read())
 
             zone = Zone('unit.tests.', [])
             provider.populate(zone)
-            self.assertEquals(10, len(zone.records))
+            self.assertEquals(11, len(zone.records))
             changes = self.expected.changes(zone, provider)
-            self.assertEquals(22, len(changes))
+            self.assertEquals(23, len(changes))
 
         # 2nd populate makes no network calls/all from cache
         again = Zone('unit.tests.', [])
         provider.populate(again)
-        self.assertEquals(10, len(again.records))
+        self.assertEquals(11, len(again.records))
 
         # bust the cache
         del provider._zone_records[zone.name]