From b80348c2c7c532c72fb8f132d660fa5853e08956 Mon Sep 17 00:00:00 2001
From: Ross McFarland <ross@github.com>
Date: Mon, 3 Dec 2018 16:46:18 -0800
Subject: [PATCH] Add __eq__, __ne__, and __repr__ to Dynamic objects and test

---
 octodns/record.py            |  28 +++++++++
 tests/test_octodns_record.py | 109 ++++++++++++++++++++++++++++++++++-
 2 files changed, 136 insertions(+), 1 deletion(-)

diff --git a/octodns/record.py b/octodns/record.py
index caac7a0..5f81e35 100644
--- a/octodns/record.py
+++ b/octodns/record.py
@@ -396,6 +396,15 @@ class _DynamicPool(object):
     def _data(self):
         return self.data
 
+    def __eq__(self, other):
+        return self.data == other.data
+
+    def __ne__(self, other):
+        return not self.__eq__(other)
+
+    def __repr__(self):
+        return '{}'.format(self.data)
+
 
 class _DynamicRule(object):
 
@@ -407,6 +416,15 @@ class _DynamicRule(object):
     def _data(self):
         return self.data
 
+    def __eq__(self, other):
+        return self.data == other.data
+
+    def __ne__(self, other):
+        return not self.__eq__(other)
+
+    def __repr__(self):
+        return '{}'.format(self.data)
+
 
 class _Dynamic(object):
 
@@ -426,6 +444,16 @@ class _Dynamic(object):
             'rules': rules,
         }
 
+    def __eq__(self, other):
+        ret = self.pools == other.pools and self.rules == other.rules
+        return ret
+
+    def __ne__(self, other):
+        return not self.__eq__(other)
+
+    def __repr__(self):
+        return '{}, {}'.format(self.pools, self.rules)
+
 
 class _DynamicMixin(object):
 
diff --git a/tests/test_octodns_record.py b/tests/test_octodns_record.py
index 5c7b7f2..4591530 100644
--- a/tests/test_octodns_record.py
+++ b/tests/test_octodns_record.py
@@ -13,7 +13,7 @@ from octodns.record import ARecord, AaaaRecord, AliasRecord, CaaRecord, \
     TxtRecord, Update, ValidationError
 from octodns.zone import Zone
 
-from helpers import GeoProvider, SimpleProvider
+from helpers import DynamicProvider, GeoProvider, SimpleProvider
 
 
 class TestRecord(TestCase):
@@ -2389,3 +2389,110 @@ class TestDynamicRecords(TestCase):
             },
             'rules': [],
         }, a._data()['dynamic'])
+
+    def test_dynamic_changes(self):
+        simple = SimpleProvider()
+        dynamic = DynamicProvider()
+
+        a_data = {
+            'dynamic': {
+                'pools': {
+                    'one': '3.3.3.3',
+                    'two': [
+                        '4.4.4.4',
+                        '5.5.5.5',
+                    ],
+                },
+                'rules': [{
+                    'pools': {
+                        100: 'one',
+                        200: 'two',
+                    }
+                }],
+            },
+            'ttl': 60,
+            'values': [
+                '1.1.1.1',
+                '2.2.2.2',
+            ],
+        }
+        a = ARecord(self.zone, 'weighted', a_data)
+        dup = ARecord(self.zone, 'weighted', a_data)
+
+        b_data = {
+            'dynamic': {
+                'pools': {
+                    'one': '3.3.3.5',
+                    'two': [
+                        '4.4.4.4',
+                        '5.5.5.5',
+                    ],
+                },
+                'rules': [{
+                    'pools': {
+                        100: 'one',
+                        200: 'two',
+                    }
+                }],
+            },
+            'ttl': 60,
+            'values': [
+                '1.1.1.1',
+                '2.2.2.2',
+            ],
+        }
+        b = ARecord(self.zone, 'weighted', b_data)
+
+        c_data = {
+            'dynamic': {
+                'pools': {
+                    'one': '3.3.3.3',
+                    'two': [
+                        '4.4.4.4',
+                        '5.5.5.5',
+                    ],
+                },
+                'rules': [{
+                    'pools': {
+                        100: 'one',
+                        300: 'two',
+                    }
+                }],
+            },
+            'ttl': 60,
+            'values': [
+                '1.1.1.1',
+                '2.2.2.2',
+            ],
+        }
+        c = ARecord(self.zone, 'weighted', c_data)
+
+        # a changes a (identical dup) is never true
+        self.assertFalse(a.changes(dup, simple))
+        self.assertFalse(a.changes(dup, dynamic))
+
+        # a changes b is not true for simple
+        self.assertFalse(a.changes(b, simple))
+        # but is true for dynamic
+        update = a.changes(b, dynamic)
+        self.assertEquals(a, update.existing)
+        self.assertEquals(b, update.new)
+        # transitive
+        self.assertFalse(b.changes(a, simple))
+        update = b.changes(a, dynamic)
+        self.assertEquals(a, update.existing)
+        self.assertEquals(b, update.new)
+
+        # same for a change c
+        self.assertFalse(a.changes(c, simple))
+        self.assertTrue(a.changes(c, dynamic))
+        self.assertFalse(c.changes(a, simple))
+        self.assertTrue(c.changes(a, dynamic))
+
+        # smoke test some of the equiality bits
+        self.assertEquals(a.dynamic.pools, a.dynamic.pools)
+        self.assertEquals(a.dynamic.pools['one'], a.dynamic.pools['one'])
+        self.assertNotEquals(a.dynamic.pools['one'], a.dynamic.pools['two'])
+        self.assertEquals(a.dynamic.rules, a.dynamic.rules)
+        self.assertEquals(a.dynamic.rules[0], a.dynamic.rules[0])
+        self.assertNotEquals(a.dynamic.rules[0], c.dynamic.rules[0])