From b913b7ed9586642704e7af079a3ded9d53129ec9 Mon Sep 17 00:00:00 2001 From: Mathurin Gagnon Date: Wed, 23 Apr 2025 16:25:47 -0700 Subject: [PATCH] added patch so when a record has an empty value it does not crash --- octodns/processor/filter.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/octodns/processor/filter.py b/octodns/processor/filter.py index 848cb6f..0ac152f 100644 --- a/octodns/processor/filter.py +++ b/octodns/processor/filter.py @@ -234,8 +234,10 @@ class _ValueBaseFilter(_FilterProcessor): if hasattr(record, 'values'): values = [value.rdata_text for value in record.values] else: - values = [record.value.rdata_text] - + try: + values = [record.value.rdata_text] + except AttributeError: + self.log.warning(f"Record value is NoneType: {record.fqdn}") if any(value in self.exact for value in values): self.matches(zone, record) continue @@ -317,6 +319,7 @@ class ValueRejectlistFilter(_ValueBaseFilter, RejectsMixin): ''' def __init__(self, name, rejectlist): + self.log = getLogger(f'ValueRejectlistFilter[{name}]') super().__init__(name, rejectlist)