Merge pull request #1185 from octodns/change-data-name

Add `name` to Change.dat, and thus PlanJson output

CHANGELOG.md

@@ -1,3 +1,7 @@
+## v1.9.? - 2024-??-?? - ???
+
+* Add `name` to Change.data, and thus PlanJson output
+
 ## v1.9.0 - 2024-06-20 - Grab bag
 
 * ICMP & UDP healthcheck protocol support added

octodns/record/change.py

@@ -29,6 +29,7 @@ class Create(Change):
     def data(self):
         return {
             'type': 'create',
+            'name': self.new.name,
             'new': self.new.data,
             'record_type': self.new._type,
         }
@@ -46,6 +47,7 @@ class Update(Change):
         return {
             'type': 'update',
             'existing': self.existing.data,
+            'name': self.new.name,
             'new': self.new.data,
             'record_type': self.new._type,
         }
@@ -73,6 +75,7 @@ class Delete(Change):
         return {
             'type': 'delete',
             'existing': self.existing.data,
+            'name': self.existing.name,
             'record_type': self.existing._type,
         }
 

tests/test_octodns_plan.py

@@ -408,7 +408,8 @@ class TestPlanSafety(TestCase):
         # have a dedicated test (file)
         delete_data = data['changes'][0]  # delete
         self.assertEqual(
-            ['existing', 'record_type', 'type'], sorted(delete_data.keys())
+            ['existing', 'name', 'record_type', 'type'],
+            sorted(delete_data.keys()),
         )
         self.assertEqual('delete', delete_data['type'])
         self.assertEqual('A', delete_data['record_type'])
@@ -416,7 +417,7 @@ class TestPlanSafety(TestCase):
 
         create_data = data['changes'][1]  # create
         self.assertEqual(
-            ['new', 'record_type', 'type'], sorted(create_data.keys())
+            ['name', 'new', 'record_type', 'type'], sorted(create_data.keys())
         )
         self.assertEqual('create', create_data['type'])
         self.assertEqual('CNAME', create_data['record_type'])
@@ -424,7 +425,7 @@ class TestPlanSafety(TestCase):
 
         update_data = data['changes'][3]  # update
         self.assertEqual(
-            ['existing', 'new', 'record_type', 'type'],
+            ['existing', 'name', 'new', 'record_type', 'type'],
             sorted(update_data.keys()),
         )
         self.assertEqual('update', update_data['type'])