From c816fe7af0af95ef3bef09d2581000b0b784f5a5 Mon Sep 17 00:00:00 2001
From: Alizey Jalil <alizeyjalil@gmail.com>
Date: Mon, 11 Dec 2023 17:43:11 +0530
Subject: [PATCH] Added test for missing zone file

---
 .DS_Store                             | Bin 0 -> 6148 bytes
 octodns/manager.py                    |   5 +++++
 tests/config/missing-zone-config.yaml |  10 ++++++++++
 tests/test_octodns_manager.py         |   5 +++++
 4 files changed, 20 insertions(+)
 create mode 100644 .DS_Store
 create mode 100644 tests/config/missing-zone-config.yaml

diff --git a/.DS_Store b/.DS_Store
new file mode 100644
index 0000000000000000000000000000000000000000..a5c2315f7bb7cc4988bd116fdc15e67a4bdf779f
GIT binary patch
literal 6148
zcmeHKJ8DBg3>+nf7}B^*xmWNF7UP`27ce*w7ydv<T))ca%F#0V5MrL)1k!{NNVBWe
z?Bh-G^aQ{bA1`xY24G5e#M#5x{M>zHca<?Bop)?-#ObtpJM505>gx&TK46P??6LdF
zKfLCx*J;X10VyB_q<|EV0>4zidoOMJn5ZZPq<|FoR=~dxjqcbBhs5}FFvJKzoG=~6
zb<7gP<_Tgi91@wKSyG8fwHh%j>CCsP>xDyN(qT1xSUuTlLa}%{?{85K>xqg|Knh$c
zaG%?m_y1@5jrsqQq@5Iy0{=<@n=Dt$1z)Lp>*(dY*Eaf^?lqruH?D)i5bc;4?U);H
e$4^m|b<Nj2?}bBR(3uZ9Q9lE&i%bgqwE|zqi50j2

literal 0
HcmV?d00001

diff --git a/octodns/manager.py b/octodns/manager.py
index 0e76132..f52457d 100644
--- a/octodns/manager.py
+++ b/octodns/manager.py
@@ -600,7 +600,12 @@ class Manager(object):
         aliased_zones = {}
         delayed_arpa = []
         futures = []
+
         for zone_name, config in zones.items():
+            if config is None:
+                raise ManagerException(
+                    f'Passed zone: {zone_name} not found in config'
+                )
             decoded_zone_name = idna_decode(zone_name)
             self.log.info('sync:   zone=%s', decoded_zone_name)
             if 'alias' in config:
diff --git a/tests/config/missing-zone-config.yaml b/tests/config/missing-zone-config.yaml
new file mode 100644
index 0000000..8b509cc
--- /dev/null
+++ b/tests/config/missing-zone-config.yaml
@@ -0,0 +1,10 @@
+manager:
+  max_workers: 2
+providers:
+  in:
+    class: octodns.provider.yaml.YamlProvider
+    directory: tests/config
+  dump:
+    class: octodns.provider.yaml.YamlProvider
+    directory: env/YAML_TMP_DIR
+zones: {}
\ No newline at end of file
diff --git a/tests/test_octodns_manager.py b/tests/test_octodns_manager.py
index 79f4318..7db4fde 100644
--- a/tests/test_octodns_manager.py
+++ b/tests/test_octodns_manager.py
@@ -79,6 +79,11 @@ class TestManager(TestCase):
             )
         self.assertTrue('missing sources' in str(ctx.exception))
 
+    def test_missing_zone(self):
+        with self.assertRaises(ManagerException) as ctx:
+            Manager(get_config_filename('missing-zone-config.yaml')).sync()
+        self.assertTrue('Passed zone:' in str(ctx.exception))
+
     def test_missing_targets(self):
         with self.assertRaises(ManagerException) as ctx:
             Manager(get_config_filename('provider-problems.yaml')).sync(