From 4256ad6caf4a11f4fe35a203dc6dfebde020f12f Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sat, 9 Sep 2023 14:35:45 -0700 Subject: [PATCH 1/2] Deprecate SpfRecord --- CHANGELOG.md | 2 ++ octodns/record/spf.py | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ce2ebed..2de5ae0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,8 @@ common records across all zones using the provider. It can be used stand-alone or in combination with zone files and/or split configs to aid in DRYing up DNS configs. +* SpfRecord is formally deprecated with an warning and will become a + ValidationError in 2.x #### Stuff diff --git a/octodns/record/spf.py b/octodns/record/spf.py index ac59c57..9eb7a4a 100644 --- a/octodns/record/spf.py +++ b/octodns/record/spf.py @@ -10,5 +10,11 @@ class SpfRecord(_ChunkedValuesMixin, Record): _type = 'SPF' _value_type = _ChunkedValue + def __init__(self, *args, **kwargs): + super().__init__(*args, **kwargs) + self.log.warning( + 'The SPF record type is DEPRECATED in favor of TXT values and will become an ValidationError in 2.0' + ) + Record.register_type(SpfRecord) From e8a88ac520f74e9f3465cc8890c3fa3ee0f2843d Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sat, 9 Sep 2023 14:46:55 -0700 Subject: [PATCH 2/2] Deprecate SpfDnsLookupProcessor --- CHANGELOG.md | 2 ++ octodns/processor/spf.py | 3 +++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2de5ae0..d4f01d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,8 @@ configs. * SpfRecord is formally deprecated with an warning and will become a ValidationError in 2.x +* SpfDnsLookupProcessor is formally deprcated in favor of the version relocated + into https://github.com/octodns/octodns-spf and will be removed in 2.x #### Stuff diff --git a/octodns/processor/spf.py b/octodns/processor/spf.py index 6867a91..dee82ed 100644 --- a/octodns/processor/spf.py +++ b/octodns/processor/spf.py @@ -55,6 +55,9 @@ class SpfDnsLookupProcessor(BaseProcessor): def __init__(self, name): self.log.debug(f"SpfDnsLookupProcessor: {name}") + self.log.warning( + 'SpfDnsLookupProcessor is DEPRECATED in favor of the version relocated into octodns-spf and will be removed in 2.0' + ) super().__init__(name) def _get_spf_from_txt_values(