Browse Source

Merge pull request #1251 from travisty-/fix/acme-processor

Fix typo in AcmeManagingProcessor
pull/1262/head
Ross McFarland 7 months ago
committed by GitHub
parent
commit
d0e15f53bf
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
4 changed files with 15 additions and 7 deletions
  1. +5
    -0
      CHANGELOG.md
  2. +1
    -1
      README.md
  3. +6
    -3
      octodns/processor/acme.py
  4. +3
    -3
      tests/test_octodns_processor_acme.py

+ 5
- 0
CHANGELOG.md View File

@ -1,3 +1,8 @@
## v1.11.? - 2025-??-?? - ???
* Correct type-o in name of AcmeManagingProcessor, backwards compatible alias
in place
## v1.11.0 - 2025-02-03 - Cleanup & deprecations with meta planning ## v1.11.0 - 2025-02-03 - Cleanup & deprecations with meta planning
* Deprecation warning for Source.populate w/o the lenient param, to be removed * Deprecation warning for Source.populate w/o the lenient param, to be removed


+ 1
- 1
README.md View File

@ -330,7 +330,7 @@ Similar to providers, but can only serve to populate records into a zone, cannot
| Processor | Description | | Processor | Description |
|--|--| |--|--|
| [AcmeMangingProcessor](/octodns/processor/acme.py) | Useful when processes external to octoDNS are managing acme challenge DNS records, e.g. LetsEncrypt |
| [AcmeManagingProcessor](/octodns/processor/acme.py) | Useful when processes external to octoDNS are managing acme challenge DNS records, e.g. LetsEncrypt |
| [AutoArpa](/octodns/processor/arpa.py) | See [Automatic PTR generation](#automatic-ptr-generation) below | | [AutoArpa](/octodns/processor/arpa.py) | See [Automatic PTR generation](#automatic-ptr-generation) below |
| [EnsureTrailingDots](/octodns/processor/trailing_dots.py) | Processor that ensures ALIAS, CNAME, DNAME, MX, NS, PTR, and SRVs have trailing dots | | [EnsureTrailingDots](/octodns/processor/trailing_dots.py) | Processor that ensures ALIAS, CNAME, DNAME, MX, NS, PTR, and SRVs have trailing dots |
| [ExcludeRootNsChanges](/octodns/processor/filter.py) | Filter that errors or warns on planned root/APEX NS records changes. | | [ExcludeRootNsChanges](/octodns/processor/filter.py) | Filter that errors or warns on planned root/APEX NS records changes. |


+ 6
- 3
octodns/processor/acme.py View File

@ -7,14 +7,14 @@ from logging import getLogger
from .base import BaseProcessor from .base import BaseProcessor
class AcmeMangingProcessor(BaseProcessor):
log = getLogger('AcmeMangingProcessor')
class AcmeManagingProcessor(BaseProcessor):
log = getLogger('AcmeManagingProcessor')
def __init__(self, name): def __init__(self, name):
''' '''
processors: processors:
acme: acme:
class: octodns.processor.acme.AcmeMangingProcessor
class: octodns.processor.acme.AcmeManagingProcessor
... ...
@ -59,3 +59,6 @@ class AcmeMangingProcessor(BaseProcessor):
existing.remove_record(record) existing.remove_record(record)
return existing return existing
AcmeMangingProcessor = AcmeManagingProcessor

+ 3
- 3
tests/test_octodns_processor_acme.py View File

@ -4,7 +4,7 @@
from unittest import TestCase from unittest import TestCase
from octodns.processor.acme import AcmeMangingProcessor
from octodns.processor.acme import AcmeManagingProcessor
from octodns.record import Record from octodns.record import Record
from octodns.zone import Zone from octodns.zone import Zone
@ -46,9 +46,9 @@ records = {
} }
class TestAcmeMangingProcessor(TestCase):
class TestAcmeManagingProcessor(TestCase):
def test_process_zones(self): def test_process_zones(self):
acme = AcmeMangingProcessor('acme')
acme = AcmeManagingProcessor('acme')
source = Zone(zone.name, []) source = Zone(zone.name, [])
# Unrelated stuff that should be untouched # Unrelated stuff that should be untouched


Loading…
Cancel
Save