Browse Source

Implement populate exists for RackspaceProvider

pull/177/head
Ross McFarland 8 years ago
parent
commit
d35fcd319a
No known key found for this signature in database GPG Key ID: 61C10C4FC8FE4A89
2 changed files with 6 additions and 3 deletions
  1. +3
    -2
      octodns/provider/rackspace.py
  2. +3
    -1
      tests/test_octodns_provider_rackspace.py

+ 3
- 2
octodns/provider/rackspace.py View File

@ -208,7 +208,7 @@ class RackspaceProvider(BaseProvider):
raise Exception('Rackspace request unauthorized')
elif e.response.status_code == 404:
# Zone not found leaves the zone empty instead of failing.
return
return False
raise
before = len(zone.records)
@ -225,8 +225,9 @@ class RackspaceProvider(BaseProvider):
source=self)
zone.add_record(record)
self.log.info('populate: found %s records',
self.log.info('populate: found %s records, exists=True',
len(zone.records) - before)
return True
def _group_records(self, all_records):
records = defaultdict(lambda: defaultdict(list))


+ 3
- 1
tests/test_octodns_provider_rackspace.py View File

@ -73,9 +73,10 @@ class TestRackspaceProvider(TestCase):
json={'error': "Could not find domain 'unit.tests.'"})
zone = Zone('unit.tests.', [])
self.provider.populate(zone)
exists = self.provider.populate(zone)
self.assertEquals(set(), zone.records)
self.assertTrue(mock.called_once)
self.assertFalse(exists)
def test_multipage_populate(self):
with requests_mock() as mock:
@ -109,6 +110,7 @@ class TestRackspaceProvider(TestCase):
plan = self.provider.plan(expected)
self.assertTrue(mock.called)
self.assertTrue(plan.exists)
# OctoDNS does not propagate top-level NS records.
self.assertEquals(1, len(plan.changes))


Loading…
Cancel
Save