Browse Source

Normalize MX exchange to lower-case, fix #322

pull/337/head
Peter Dave Hello 7 years ago
parent
commit
e0a8a619d6
2 changed files with 12 additions and 1 deletions
  1. +1
    -1
      octodns/record/__init__.py
  2. +11
    -0
      tests/test_octodns_record.py

+ 1
- 1
octodns/record/__init__.py View File

@ -852,7 +852,7 @@ class MxValue(object):
exchange = value['exchange'] exchange = value['exchange']
except KeyError: except KeyError:
exchange = value['value'] exchange = value['value']
self.exchange = exchange
self.exchange = exchange.lower()
@property @property
def data(self): def data(self):


+ 11
- 0
tests/test_octodns_record.py View File

@ -354,6 +354,17 @@ class TestRecord(TestCase):
self.assertEquals(b_value['exchange'], b.values[0].exchange) self.assertEquals(b_value['exchange'], b.values[0].exchange)
self.assertEquals(b_data, b.data) self.assertEquals(b_data, b.data)
a_upper_values = [{
'preference': 10,
'exchange': 'SMTP1.'
}, {
'priority': 20,
'value': 'SMTP2.'
}]
a_upper_data = {'ttl': 30, 'values': a_upper_values}
a_upper = MxRecord(self.zone, 'a', a_upper_data)
self.assertEquals(a_upper.data, a.data)
target = SimpleProvider() target = SimpleProvider()
# No changes with self # No changes with self
self.assertFalse(a.changes(a, target)) self.assertFalse(a.changes(a, target))


Loading…
Cancel
Save