From f52005bf60d75b3c5c73bfe6af3bd09ccd6938e4 Mon Sep 17 00:00:00 2001 From: Ross McFarland Date: Sun, 9 Dec 2018 14:24:53 -0800 Subject: [PATCH] Fix deletion of Cloudflare ALIAS reocrds --- octodns/provider/cloudflare.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/octodns/provider/cloudflare.py b/octodns/provider/cloudflare.py index e4e0a34..b2d670d 100644 --- a/octodns/provider/cloudflare.py +++ b/octodns/provider/cloudflare.py @@ -524,9 +524,12 @@ class CloudflareProvider(BaseProvider): def _apply_Delete(self, change): existing = change.existing existing_name = existing.fqdn[:-1] + # Make sure to map ALIAS to CNAME when looking for the target to delete + existing_type = 'CNAME' if existing._type == 'ALIAS' \ + else existing._type for record in self.zone_records(existing.zone): if existing_name == record['name'] and \ - existing._type == record['type']: + existing_type == record['type']: path = '/zones/{}/dns_records/{}'.format(record['zone_id'], record['id']) self._request('DELETE', path)