From f590f201ead5bd1767994b9c4d2d134c91961e97 Mon Sep 17 00:00:00 2001 From: Maik Zumstrull Date: Thu, 26 Mar 2020 14:23:36 +0000 Subject: [PATCH] Use dict to speed up record search This dict is created earlier, presumably to speed up this exact lookup, but it was using the list form instead, requiring a linear scan for each item. --- octodns/provider/cloudflare.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/octodns/provider/cloudflare.py b/octodns/provider/cloudflare.py index d83a523..9d769e4 100644 --- a/octodns/provider/cloudflare.py +++ b/octodns/provider/cloudflare.py @@ -585,7 +585,7 @@ class CloudflareProvider(BaseProvider): changed_records = {c.record for c in changes} for desired_record in desired.records: - if desired_record not in existing.records: # Will be created + if desired_record not in existing_records: # Will be created continue elif desired_record in changed_records: # Already being updated continue