Add a Name tag to Route53 healthchecks for UI purposes

octodns/provider/route53.py

@@ -640,6 +640,20 @@ class Route53Provider(BaseProvider):
                                               HealthCheckConfig=config)
         health_check = resp['HealthCheck']
         id = health_check['Id']
+
+        # Set a Name for the benefit of the UI
+        name = '{}:{} - {}'.format(record.fqdn, record._type, value)
+        self._conn.change_tags_for_resource(ResourceType='healthcheck',
+                                            ResourceId=id,
+                                            AddTags=[{
+                                                'Key': 'Name',
+                                                'Value': name,
+                                            }])
+        # Manually add it to our cache
+        health_check['Tags'] = {
+            'Name': name
+        }
+
         # store the new health check so that we'll be able to find it in the
         # future
         self._health_checks[id] = health_check

tests/test_octodns_provider_route53.py

@@ -841,6 +841,7 @@ class TestRoute53Provider(TestCase):
             'CallerReference': ANY,
             'HealthCheckConfig': health_check_config,
         })
+        stubber.add_response('change_tags_for_resource', {})
 
         record = Record.new(self.expected, '', {
             'ttl': 61,
@@ -947,6 +948,8 @@ class TestRoute53Provider(TestCase):
             'CallerReference': ANY,
             'HealthCheckConfig': health_check_config,
         })
+        stubber.add_response('change_tags_for_resource', {})
+        stubber.add_response('change_tags_for_resource', {})
 
         record = Record.new(self.expected, 'a', {
             'ttl': 61,