From fa266c23d2e4cb6debab32107e7503c90a9fe375 Mon Sep 17 00:00:00 2001 From: Mark Tearle Date: Wed, 25 Nov 2020 22:28:35 +0800 Subject: [PATCH] Fix _is_valid_dkim_key for Python 3.9 compatibility in OVH provider base64.decodestring was deprecated and removed in Python 3.9 in favour of decodebytes (See https://bugs.python.org/issue39351 ) --- octodns/provider/ovh.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/octodns/provider/ovh.py b/octodns/provider/ovh.py index 54f62ac..0ee8e61 100644 --- a/octodns/provider/ovh.py +++ b/octodns/provider/ovh.py @@ -370,11 +370,16 @@ class OvhProvider(BaseProvider): @staticmethod def _is_valid_dkim_key(key): + result = True try: - base64.decodestring(bytearray(key, 'utf-8')) + decode = base64.decodestring + except AttributeError: + decode = base64.decodebytes + try: + result = decode(bytearray(key, 'utf-8')) except binascii.Error: - return False - return True + result = False + return result def get_records(self, zone_name): """