From 0dc4f986485f0d5b3aeae56b346c39c16fccc925 Mon Sep 17 00:00:00 2001
From: Richard Fuchs <rfuchs@sipwise.com>
Date: Mon, 28 Apr 2025 09:57:35 -0400
Subject: [PATCH] MT#55283 make shellcheck happy

Fix quoting.
Fix unused variable.
Fix variable naming.

Change-Id: I9c4286a5f46d60247e3a31eabc513c8da7fb35bd
(cherry picked from commit 8d1cfbda7dc37e3e6b70805a0a3cd0469ff6fba2)
(cherry picked from commit 39090db921d2f8b1bb8b15d7a23e91fa9e44ad34)
---
 utils/gen-common-flags | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/utils/gen-common-flags b/utils/gen-common-flags
index 63c447486..09f3bd8e3 100755
--- a/utils/gen-common-flags
+++ b/utils/gen-common-flags
@@ -21,7 +21,7 @@ fi
 
 if [ -z "${RELEASE_DATE}" ]; then
   if [ "${have_dpkg_parsechangelog}" = yes ]; then
-    RELEASE_DATE="$(date -u -d "@$(dpkg-parsechangelog -l${top_srcdir}/debian/changelog -STimestamp)" '+%F')"
+    RELEASE_DATE="$(date -u -d "@$(dpkg-parsechangelog -l"${top_srcdir}"/debian/changelog -STimestamp)" '+%F')"
   fi
   if [ -z "${RELEASE_DATE}" ]; then
     RELEASE_DATE="undefined"
@@ -31,7 +31,7 @@ echo "RELEASE_DATE = ${RELEASE_DATE}"
 
 if [ -z "${RTPENGINE_VERSION}" ]; then
   if [ "${have_dpkg_parsechangelog}" = yes ]; then
-    deb_version="$(dpkg-parsechangelog -l${top_srcdir}/debian/changelog | awk '/^Version: / { print $2 }')"
+    deb_version="$(dpkg-parsechangelog -l"${top_srcdir}"/debian/changelog | awk '/^Version: / { print $2 }')"
   fi
   git_br_commit="git-$(git rev-parse --abbrev-ref --symbolic-full-name HEAD 2> /dev/null)-$(git rev-parse --short HEAD 2> /dev/null)"
 
@@ -51,12 +51,11 @@ echo "RTPENGINE_VERSION := ${RTPENGINE_VERSION}"
 CFLAGS_DEFAULT=
 CPPFLAGS_DEFAULT=
 LDFLAGS_DEFAULT=
-LDLIBS_DEFAULT=
 if command -v dpkg-buildflags >/dev/null; then
   # support http://wiki.debian.org/Hardening for >=wheezy
   CFLAGS_DEFAULT=$(dpkg-buildflags --get CFLAGS)
   CPPFLAGS_DEFAULT=$(dpkg-buildflags --get CPPFLAGS)
-  LDFLAGS=$(dpkg-buildflags --get LDFLAGS)
+  LDFLAGS_DEFAULT=$(dpkg-buildflags --get LDFLAGS)
 fi
 CFLAGS_DEFAULT+=" -O3 -flto=auto -ffat-lto-objects"
 LDFLAGS_DEFAULT+=" -flto=auto"