MT#55283 remove bidirectional ZERO_ADDR setting

This flag is relevant to copy the state from A to B during an
offer/answer. It should only be set on one side, not on both.

Change-Id: Ie5c6de58a4ca11b37526b719b1937ffb08ebf512

daemon/call.c

@@ -1415,12 +1415,6 @@ static bool __streams_set_sinks(struct call_media *A, struct call_media *B,
 		else if (b)
 			__add_sink_handler(&a->rtcp_sinks, b, attrs);
 
-		if (is_addr_unspecified(&b->advertised_endpoint.address)
-				&& !(is_trickle_ice_address(&b->advertised_endpoint)
-					&& MEDIA_ISSET(B, TRICKLE_ICE))
-				&& !(flags && flags->replace_zero_address))
-			PS_SET(a, ZERO_ADDR);
-
 no_rtcp:
 		la = la->next;
 		lb = lb->next;

t/auto-daemon-tests-redis-json.pl

@@ -274,7 +274,7 @@ $json_exp = {
 		  'endpoint' => '198.51.100.1:3001',
 		  'last_packet' => qr/^\d+$/,
 		  'media' => '0',
-		  'ps_flags' => '68288513',
+		  'ps_flags' => '1179649',
 		  'rtcp_sibling' => '4294967295',
 		  'sfd' => '3',
 		  'stats-bytes' => '0',
@@ -799,7 +799,7 @@ $json_exp = {
 		  'endpoint' => '198.51.100.14:6089',
 		  'last_packet' => qr/^\d+$/,
 		  'media' => '0',
-		  'ps_flags' => '68288513',
+		  'ps_flags' => '1179649',
 		  'rtcp_sibling' => '4294967295',
 		  'sfd' => '3',
 		  'stats-bytes' => '0',
@@ -1406,7 +1406,7 @@ $json_exp = {
                           'endpoint' => '198.51.100.14:6091',
                           'last_packet' => qr/^\d+$/,
                           'media' => '1',
-                          'ps_flags' => '68288513',
+                          'ps_flags' => '1179649',
                           'rtcp_sibling' => '4294967295',
                           'sfd' => '1',
                           'stats-bytes' => '0',
@@ -1432,7 +1432,7 @@ $json_exp = {
                           'endpoint' => '198.51.100.14:6089',
                           'last_packet' => qr/^\d+$/,
                           'media' => '0',
-                          'ps_flags' => '68288513',
+                          'ps_flags' => '1179649',
                           'rtcp_sibling' => '4294967295',
                           'sfd' => '3',
                           'stats-bytes' => '0',
@@ -1930,7 +1930,7 @@ $json_exp = {
 		  'endpoint' => '198.51.100.14:6043',
 		  'last_packet' => qr//,
 		  'media' => '0',
-		  'ps_flags' => '68288513',
+		  'ps_flags' => '1179649',
 		  'rtcp_sibling' => '4294967295',
 		  'sfd' => '1',
 		  'stats-bytes' => '0',
@@ -2466,7 +2466,7 @@ $json_exp = {
 		  'endpoint' => '198.51.100.14:6043',
 		  'last_packet' => qr//,
 		  'media' => '0',
-		  'ps_flags' => '68288513',
+		  'ps_flags' => '1179649',
 		  'rtcp_sibling' => '4294967295',
 		  'sfd' => '1',
 		  'stats-bytes' => '0',

t/auto-daemon-tests-redis.pl

@@ -273,7 +273,7 @@ $json_exp = {
 		  'endpoint' => '198.51.100.1:3001',
 		  'last_packet' => qr/^\d+$/,
 		  'media' => '0',
-		  'ps_flags' => '68288513',
+		  'ps_flags' => '1179649',
 		  'rtcp_sibling' => '4294967295',
 		  'sfd' => '3',
 		  'stats-bytes' => '0',
@@ -1065,7 +1065,7 @@ $json_exp = {
 		  'endpoint' => '198.51.100.14:6089',
 		  'last_packet' => qr/^\d+$/,
 		  'media' => '0',
-		  'ps_flags' => '68288513',
+		  'ps_flags' => '1179649',
 		  'rtcp_sibling' => '4294967295',
 		  'sfd' => '3',
 		  'stats-bytes' => '0',
@@ -1672,7 +1672,7 @@ $json_exp = {
                           'endpoint' => '198.51.100.14:6091',
                           'last_packet' => qr/^\d+$/,
                           'media' => '1',
-                          'ps_flags' => '68288513',
+                          'ps_flags' => '1179649',
                           'rtcp_sibling' => '4294967295',
                           'sfd' => '1',
                           'stats-bytes' => '0',
@@ -1698,7 +1698,7 @@ $json_exp = {
                           'endpoint' => '198.51.100.14:6089',
                           'last_packet' => qr/^\d+$/,
                           'media' => '0',
-                          'ps_flags' => '68288513',
+                          'ps_flags' => '1179649',
                           'rtcp_sibling' => '4294967295',
                           'sfd' => '3',
                           'stats-bytes' => '0',
@@ -2195,7 +2195,7 @@ $json_exp = {
 		  'endpoint' => '198.51.100.14:6043',
 		  'last_packet' => qr//,
 		  'media' => '0',
-		  'ps_flags' => '68288513',
+		  'ps_flags' => '1179649',
 		  'rtcp_sibling' => '4294967295',
 		  'sfd' => '1',
 		  'stats-bytes' => '0',
@@ -2731,7 +2731,7 @@ $json_exp = {
 		  'endpoint' => '198.51.100.14:6043',
 		  'last_packet' => qr//,
 		  'media' => '0',
-		  'ps_flags' => '68288513',
+		  'ps_flags' => '1179649',
 		  'rtcp_sibling' => '4294967295',
 		  'sfd' => '1',
 		  'stats-bytes' => '0',