From 1e1e1d73427b16dcf397d70f12c01b84086c24e9 Mon Sep 17 00:00:00 2001 From: Richard Fuchs Date: Fri, 5 Dec 2025 08:23:30 -0400 Subject: [PATCH] MT#55283 fix possible fd leak Change-Id: I5434863e1694161acfb60d76b5a32533b080b4b1 Warned-by: Coverity --- lib/netfilter_api.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/netfilter_api.c b/lib/netfilter_api.c index 1dff42a22..6ae934386 100644 --- a/lib/netfilter_api.c +++ b/lib/netfilter_api.c @@ -36,14 +36,18 @@ nfapi_socket *nfapi_socket_open(void) { return NULL; int ret = bind(fd, (struct sockaddr *) &zero_nl_sockaddr, sizeof(zero_nl_sockaddr)); - if (ret != 0) + if (ret != 0) { + close(fd); return NULL; + } struct sockaddr_nl saddr; socklen_t slen = sizeof(saddr); ret = getsockname(fd, (struct sockaddr *) &saddr, &slen); - if (slen < sizeof(saddr)) + if (slen < sizeof(saddr)) { + close(fd); return NULL; + } nfapi_socket *s = g_new0(__typeof(*s), 1); s->fd = fd;