From 28884150b7a3872951a39faccafc85856a1a89d9 Mon Sep 17 00:00:00 2001 From: Richard Fuchs Date: Fri, 15 Aug 2025 09:50:03 -0400 Subject: [PATCH] MT#61977 remove logically dead test if ((output_storage & OUTPUT_STORAGE_MEMORY)) goto no_output_file; jumps over this code, so there's no point in testing for OUTPUT_STORAGE_MEMORY Change-Id: I95eec8904714c9ab06f066ac4bb59ec0413e6916 --- recording-daemon/output.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/recording-daemon/output.c b/recording-daemon/output.c index 070f04966..aec45af15 100644 --- a/recording-daemon/output.c +++ b/recording-daemon/output.c @@ -441,11 +441,9 @@ got_fn: output->filename = full_fn; err = "failed to open output file"; - if (!(output_storage & OUTPUT_STORAGE_MEMORY)) { - output->fp = fopen(full_fn, (output_storage & OUTPUT_STORAGE_DB) ? "wb+" : "wb"); - if (!output->fp) - goto err; - } + output->fp = fopen(full_fn, (output_storage & OUTPUT_STORAGE_DB) ? "wb+" : "wb"); + if (!output->fp) + goto err; if (output_buffer > 0) { err = "failed to alloc I/O buffer";