Browse Source

MT#60476 Fix dead code in `print_sdp_media_section()`

0f9dd5def2 introduced this check for `source_media`
which was only in use by `sdp_replace()` functionality.

`sdp_create()`'s one never really reaches it, even
in older implementation where `handle_sdp_media_attributes()`
was used.

So for now it has no use, just remove it.

Fixes:

*** CID 1600058:  Control flow issues  (DEADCODE)
/daemon/sdp.c: 2690 in print_sdp_media_section()
2684
2685            /* print sendrecv */
2686            if (!flags->original_sendrecv)
2687                    append_attr_to_gstring(s, sdp_get_sendrecv(media), NULL, flags,
2688                                    media->type_id);
2689            else if (source_media)
>>>     CID 1600058:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "append_attr_to_gstring(s, s...".
2690                    append_attr_to_gstring(s, sdp_get_sendrecv(source_media), NULL, flags,
2691                                    media->type_id);
2692
2693            ps_rtcp = print_rtcp(s, media, rtp_ps_link, flags);
2694
2695            if (proto_is_rtp(media->protocol)) {

** CID 1600057:  Null pointer dereferences  (NULL_RETURNS)

Change-Id: I2d2ffbb0c9ecc0fae8890367754fbbd6e79e9c21
pull/1870/head
Donat Zenichev 1 year ago
parent
commit
424cdf2a8c
1 changed files with 0 additions and 3 deletions
  1. +0
    -3
      daemon/sdp.c

+ 0
- 3
daemon/sdp.c View File

@ -2686,9 +2686,6 @@ static void print_sdp_media_section(GString *s, struct call_media *media,
if (!flags->original_sendrecv)
append_attr_to_gstring(s, sdp_get_sendrecv(media), NULL, flags,
media->type_id);
else if (source_media)
append_attr_to_gstring(s, sdp_get_sendrecv(source_media), NULL, flags,
media->type_id);
ps_rtcp = print_rtcp(s, media, rtp_ps_link, flags);


Loading…
Cancel
Save