Browse Source

TT#115400 explicitly disallow ptime in non-RTP SDPs

Change-Id: Ib1e324861b6a88e1a2f80e4f37a8afa654923a77
(cherry picked from commit e2bf4abee8)
pull/1219/head
Richard Fuchs 5 years ago
parent
commit
5cf4717f89
3 changed files with 1 additions and 5 deletions
  1. +1
    -1
      daemon/sdp.c
  2. +0
    -2
      t/auto-daemon-tests-reorder.pl
  3. +0
    -2
      t/auto-daemon-tests.pl

+ 1
- 1
daemon/sdp.c View File

@ -2656,7 +2656,7 @@ int sdp_replace(struct sdp_chopper *chop, GQueue *sessions, struct call_monologu
insert_crypto(call_media, chop, flags);
insert_dtls(call_media, chop);
if (call_media->ptime)
if (proto_is_rtp(call_media->protocol) && call_media->ptime)
chopper_append_printf(chop, "a=ptime:%i\r\n", call_media->ptime);
if (MEDIA_ISSET(call_media, ICE) && call_media->ice_agent) {


+ 0
- 2
t/auto-daemon-tests-reorder.pl View File

@ -6956,7 +6956,6 @@ a=T38FaxMaxBuffer:200
a=T38FaxMaxDatagram:180
a=T38FaxUdpEC:t38UDPRedundancy
a=sendrecv
a=ptime:20
SDP
(undef, $port_a) = answer('gh 766 reinvite', {
@ -6990,7 +6989,6 @@ a=T38FaxMaxBuffer:262
a=T38FaxMaxDatagram:176
a=T38FaxUdpEC:t38UDPRedundancy
a=sendrecv
a=ptime:20
SDP
snd($sock_b, $port_a, rtp(0, 4000, 5000, 0x4567, "\x88" x 160));


+ 0
- 2
t/auto-daemon-tests.pl View File

@ -12372,7 +12372,6 @@ a=T38FaxMaxBuffer:200
a=T38FaxMaxDatagram:180
a=T38FaxUdpEC:t38UDPRedundancy
a=sendrecv
a=ptime:20
SDP
(undef, $port_a) = answer('gh 766 reinvite', {
@ -12406,7 +12405,6 @@ a=T38FaxMaxBuffer:262
a=T38FaxMaxDatagram:176
a=T38FaxUdpEC:t38UDPRedundancy
a=sendrecv
a=ptime:20
SDP
snd($sock_b, $port_a, rtp(0, 4000, 5000, 0x4567, "\x88" x 160));


Loading…
Cancel
Save