From 82a2cf4e18105ab8f59944ed23d4aa84a0fbcb4e Mon Sep 17 00:00:00 2001 From: Richard Fuchs Date: Wed, 16 Feb 2022 09:55:47 -0500 Subject: [PATCH] TT#14008 don't skip parsing a=rtcp with a=rtcp-mux Setting the mux flag when rtcp-mux is given is fine, but we must still provide an RTCP endpoint in case rtcp-mux ends up not being used, either through an implicit RTCP endpoint or through a=rtcp. relevant to #1443 Change-Id: I0710a50c31974f5e06bd94b47076a272bcca7a43 (cherry picked from commit e3951449ed23410c886f1946b5957d47fe503405) --- daemon/sdp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/daemon/sdp.c b/daemon/sdp.c index cbc9d02df..b3a7fd1bb 100644 --- a/daemon/sdp.c +++ b/daemon/sdp.c @@ -1666,10 +1666,8 @@ int sdp_streams(const GQueue *sessions, GQueue *streams, struct sdp_ng_flags *fl /* determine RTCP endpoint */ - if (attr_get_by_id(&media->attributes, ATTR_RTCP_MUX)) { + if (attr_get_by_id(&media->attributes, ATTR_RTCP_MUX)) SP_SET(sp, RTCP_MUX); - goto next; - } attr = attr_get_by_id(&media->attributes, ATTR_RTCP); if (!attr || media->port_count != 1) {