Browse Source

MT#55283 remove unneeded NULL check

`sdp_address` is always non-NULL

Change-Id: I53067e1b46b8ce0843b872d2feb02f426adeb579
Warned-by: Coverity
pull/1870/head
Richard Fuchs 1 year ago
parent
commit
9f88270642
1 changed files with 2 additions and 4 deletions
  1. +2
    -4
      daemon/sdp.c

+ 2
- 4
daemon/sdp.c View File

@ -3032,8 +3032,7 @@ static struct call_media *sdp_out_set_source_media_address(struct call_media *me
{
struct call_media *source_media = NULL;
/* the port and address that goes into the SDP also depends on this */
if (sdp_address)
*sdp_address = rtp_ps->selected_sfd ? &rtp_ps->selected_sfd->socket.local : NULL;
*sdp_address = rtp_ps->selected_sfd ? &rtp_ps->selected_sfd->socket.local : NULL;
struct media_subscription *ms = media->media_subscriptions.head ? media->media_subscriptions.head->data : NULL;
if (ms && ms->media) {
@ -3042,8 +3041,7 @@ static struct call_media *sdp_out_set_source_media_address(struct call_media *me
if (media->type_id == MT_MESSAGE || flags->ice_option == ICE_FORCE_RELAY || MEDIA_ISSET(media, PASSTHRU)) {
if (source_media->streams.head) {
__auto_type sub_ps = ms->media->streams.head->data;
if (sdp_address)
*sdp_address = &sub_ps->advertised_endpoint;
*sdp_address = &sub_ps->advertised_endpoint;
}
return source_media;
}


Loading…
Cancel
Save