From cd0b948b184577a121b8514289393cc6a964dd83 Mon Sep 17 00:00:00 2001
From: Donat Zenichev <dzenichev@sipwise.com>
Date: Wed, 2 Apr 2025 11:57:36 +0200
Subject: [PATCH] MT#62272 auto-daemon-tests-moh: make sure no RTP after call
 finished

Make sure that in tests with MoH there are no RTP packets
coming after the call is done.

Expected is that all packets have been received
during the signaling exchange.

Change-Id: I861f53ea108c2f0cf9f808bf6954ccd145f487fc
---
 t/auto-daemon-tests-moh.pl | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/t/auto-daemon-tests-moh.pl b/t/auto-daemon-tests-moh.pl
index b88b99d35..7c3d96a04 100644
--- a/t/auto-daemon-tests-moh.pl
+++ b/t/auto-daemon-tests-moh.pl
@@ -118,6 +118,12 @@ a=recvonly
 a=rtcp:PORT
 SDP
 
+rcv($sock_b, -1, rtpm(8, $seq + 5, $ts + 160 * 5, $ssrc, $pcma_1));
+rcv($sock_b, -1, rtpm(8, $seq + 6, $ts + 160 * 6, $ssrc, $pcma_2));
+rcv($sock_b, -1, rtpm(8, $seq + 7, $ts + 160 * 7, $ssrc, $pcma_3));
+rcv($sock_b, -1, rtpm(8, $seq + 8, $ts + 160 * 8, $ssrc, $pcma_4));
+rcv($sock_b, -1, rtpm(8, $seq + 9, $ts + 160 * 9, $ssrc, $pcma_5));
+
 # offerer puts off hold
 offer('Music on hold - MoH put off by offerer', { ICE => 'remove', DTLS => 'off' }, <<SDP);
 v=0
@@ -159,6 +165,10 @@ a=sendrecv
 a=rtcp:PORT
 SDP
 
+# make sure no RTP flows after call is done.
+rcv_maybe($sock_b);
+rcv_no($sock_b);
+
 # test MoH zero-connection
 
 ($sock_a, $sock_b) = new_call([qw(198.51.100.1 33044)], [qw(198.51.100.3 33046)]);
@@ -295,6 +305,10 @@ a=sendrecv
 a=rtcp:PORT
 SDP
 
+# make sure no RTP flows after call is done.
+rcv_maybe($sock_b);
+rcv_no($sock_b);
+
 # test MoH sendrecv mode
 
 ($sock_a, $sock_b) = new_call([qw(198.51.100.1 33048)], [qw(198.51.100.3 33050)]);
@@ -431,6 +445,10 @@ a=sendrecv
 a=rtcp:PORT
 SDP
 
+# make sure no RTP flows after call is done.
+rcv_maybe($sock_b);
+rcv_no($sock_b);
+
 # test MoH zero-connection + mode sendrecv
 
 ($sock_a, $sock_b) = new_call([qw(198.51.100.1 33052)], [qw(198.51.100.3 33054)]);
@@ -567,6 +585,10 @@ a=sendrecv
 a=rtcp:PORT
 SDP
 
+# make sure no RTP flows after call is done.
+rcv_maybe($sock_b);
+rcv_no($sock_b);
+
 # test MoH for answerer
 
 ($sock_a, $sock_b) = new_call([qw(198.51.100.1 33056)], [qw(198.51.100.3 33058)]);
@@ -705,6 +727,9 @@ a=sendrecv
 a=rtcp:PORT
 SDP
 
+# make sure no RTP flows after call is done.
+rcv_maybe($sock_b);
+rcv_no($sock_b);
 
 # test MoH for answerer (inactive)
 
@@ -844,6 +869,10 @@ a=sendrecv
 a=rtcp:PORT
 SDP
 
+# make sure no RTP flows after call is done.
+rcv_maybe($sock_b);
+rcv_no($sock_b);
+
 # test MoH, double hold
 
 ($sock_a, $sock_b) = new_call([qw(198.51.100.1 33064)], [qw(198.51.100.3 33066)]);
@@ -935,6 +964,10 @@ a=recvonly
 a=rtcp:PORT
 SDP
 
+# make sure no RTP flows after call is done.
+rcv_maybe($sock_b);
+rcv_no($sock_b);
+
 # test MoH for answerer with reflect
 
 ($sock_a, $sock_b) = new_call([qw(198.51.100.1 33068)], [qw(198.51.100.3 33070)]);
@@ -1073,5 +1106,9 @@ a=sendrecv
 a=rtcp:PORT
 SDP
 
+# make sure no RTP flows after call is done.
+rcv_maybe($sock_b);
+rcv_no($sock_b);
+
 #done_testing;NGCP::Rtpengine::AutoTest::terminate('f00');exit;
 done_testing();