Browse Source

MT#60476 Deprecate the sdp_manipulations remove/subst

Because currently it is directly handled by the
`generic_append_attr_to_gstring()` implementation, a couple
of functions (previously used by the sdp_replace)
are from now on obsolete and not needed anymore:
- `sdp_manipulations_subst_attr()`
- `sdp_manipulate_remove_attr()`

Just remove them.

Change-Id: Ia33218fa4c144812ff3265abafb62fd7f50f6955
pull/1870/head
Donat Zenichev 1 year ago
parent
commit
d6a1940735
1 changed files with 0 additions and 34 deletions
  1. +0
    -34
      daemon/sdp.c

+ 0
- 34
daemon/sdp.c View File

@ -343,22 +343,6 @@ static bool sdp_manipulate_remove_c(const char *attr_name, const sdp_ng_flags *f
return sdp_manipulate_remove(sdp_manipulations, &STR(attr_name));
}
/**
* Checks whether an attribute removal request exists for a given session level.
* `attr_name` must be without `a=`.
*/
static bool sdp_manipulate_remove_attr(struct sdp_manipulations *sdp_manipulations,
const struct sdp_attribute *attr)
{
if (sdp_manipulate_remove(sdp_manipulations, &attr->strs.key))
return true;
if (sdp_manipulate_remove(sdp_manipulations, &attr->strs.name))
return true;
if (sdp_manipulate_remove(sdp_manipulations, &attr->strs.line_value))
return true;
return false;
}
/**
* Adds values into a requested session level (global, audio, video)
*/
@ -399,24 +383,6 @@ static str *sdp_manipulations_subst(struct sdp_manipulations * sdp_manipulations
return cmd_subst_value;
}
/**
* Substitute values for a requested session level (global, audio, video).
* `attr_name` must be without `a=`.
*/
static str *sdp_manipulations_subst_attr(struct sdp_manipulations * sdp_manipulations,
const struct sdp_attribute * attr)
{
str * cmd_subst_value;
if ((cmd_subst_value = sdp_manipulations_subst(sdp_manipulations, &attr->strs.key)))
return cmd_subst_value;
if ((cmd_subst_value = sdp_manipulations_subst(sdp_manipulations, &attr->strs.name)))
return cmd_subst_value;
if ((cmd_subst_value = sdp_manipulations_subst(sdp_manipulations, &attr->strs.line_value)))
return cmd_subst_value;
return NULL;
}
static void append_str_attr_to_gstring(GString *s, const str * name, const str * value,
const sdp_ng_flags *flags, enum media_type media_type);
static void append_attr_int_to_gstring(GString *s, const char * value, const int additional,


Loading…
Cancel
Save