From dfbadf004ec2cacc8e4455e62203a2bd69e7e389 Mon Sep 17 00:00:00 2001 From: Richard Fuchs Date: Thu, 25 Jul 2024 14:54:59 -0400 Subject: [PATCH] MT#55283 remove redundant string parsing `delete-delay` is already parsed using bencode_dictionary_get_int_str() so we don't need to special-handle string type values Change-Id: If9758ccfbbe18674b7731aa53b9de5bd3fd87ae4 --- daemon/call_interfaces.c | 10 +--------- daemon/control_ng_flags_parser.c | 7 ------- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/daemon/call_interfaces.c b/daemon/call_interfaces.c index c094445d0..39f2d54df 100644 --- a/daemon/call_interfaces.c +++ b/daemon/call_interfaces.c @@ -2337,16 +2337,8 @@ const char *call_delete_ng(bencode_item_t *input, bencode_item_t *output) { } } delete_delay = bencode_dictionary_get_int_str(input, "delete-delay", -1); - if (delete_delay == -1) { + if (delete_delay == -1) delete_delay = bencode_dictionary_get_int_str(input, "delete delay", -1); - if (delete_delay == -1) { - /* legacy support */ - str s; - bencode_dictionary_get_str(input, "delete-delay", &s); - if (s.s) - delete_delay = str_to_i(&s, -1); - } - } call_t *c = call_get(&callid); if (!c) diff --git a/daemon/control_ng_flags_parser.c b/daemon/control_ng_flags_parser.c index 64c90abcd..b09d74ffe 100644 --- a/daemon/control_ng_flags_parser.c +++ b/daemon/control_ng_flags_parser.c @@ -317,13 +317,6 @@ void parse_rtpp_flags(const str * rtpp_flags, bencode_buffer_t * buf, goto generic; goto next; break; - case 12: - if (val.s && str_eq(&key, "delete-delay")) { - call_ng_main_flags(out, &key, bencode_integer(buf, atoi(val.s)), opmode); - } else - goto generic; - goto next; - break; case 16: /* transport */ if (!val.s && str_eq(&key, "UDP/TLS/RTP/SAVP"))