MT#55283 set output-dest even if not active yet

Make it possible to set output-destination immediately when starting the
reording, not only afterwards.

Closes #1667

Change-Id: Idb7de770ad5a41d6ae6055784213e7983df9bfec

daemon/call_interfaces.c

@@ -1607,6 +1607,9 @@ static void call_ng_main_flags(struct sdp_ng_flags *out, str *key, bencode_item_
 		case CSH_LOOKUP("record-call"):
 			out->record_call_str = s;
 			break;
+		case CSH_LOOKUP("output-destination"):
+			out->output_dest = s;
+			break;
 		case CSH_LOOKUP("address family"):
 		case CSH_LOOKUP("address-family"):
 			if (bencode_get_str(value, &out->address_family_str))

daemon/recording.c

@@ -319,10 +319,9 @@ static void recording_update_flags(struct call *call, bool streams) {
 
 // lock must be held
 void recording_start(struct call *call, const char *prefix, const str *output_dest) {
-	update_output_dest(call, output_dest);
-
 	if (call->recording) {
 		// already active
+		update_output_dest(call, output_dest);
 		recording_update_flags(call, true);
 		return;
 	}
@@ -350,6 +349,7 @@ void recording_start(struct call *call, const char *prefix, const str *output_de
 	// update main call flags (global recording/forwarding on/off) to prevent recording
 	// features from being started when the stream info (through setup_stream) is
 	// propagated if recording is actually off
+	update_output_dest(call, output_dest);
 	recording_update_flags(call, false);
 
 	// if recording has been turned on after initial call setup, we must walk
@@ -426,7 +426,7 @@ void detect_setup_recording(struct call *call, const struct sdp_ng_flags *flags)
 
 	if (!str_cmp(recordcall, "yes") || !str_cmp(recordcall, "on") || flags->record_call) {
 		call->recording_on = 1;
-		recording_start(call, NULL, NULL);
+		recording_start(call, NULL, &flags->output_dest);
 	}
 	else if (!str_cmp(recordcall, "no") || !str_cmp(recordcall, "off")) {
 		call->recording_on = 0;

docs/ng_control_protocol.md

@@ -435,6 +435,10 @@ Optionally included keys are:
         Short for both `accept-RFC` and `accept-legacy`. Can be used
         unconditionally in all signalling if so desired.
 
+* `output-destination`
+
+    See `start recording` below.
+
 * `ptime`
 
 	Contains an integer. If set, changes the `a=ptime` attribute's value in the outgoing
@@ -1710,7 +1714,7 @@ call legs, therefore all keys other than `call-id` are currently ignored.
 If the chosen recording method doesn't support in-kernel packet forwarding, enabling call recording
 via this messages will force packet forwarding to happen in userspace only.
 
-If the optional 'output-destination' key is set, then its value will be used
+If the optional `output-destination` key is set, then its value will be used
 as an output file. Note that a filename extension will not be added.
 
 ## `stop recording` Message

include/call_interfaces.h

@@ -36,6 +36,7 @@ struct sdp_ng_flags {
 	sockfamily_t *address_family;
 	int tos;
 	str record_call_str;
+	str output_dest;
 	str metadata;
 	str label;
 	str set_label;