rand_hex_string() writes a terminated null byte, therefore the buffer
must be larger by one byte.

Change-Id: Ieca67754d67fd7e5f1c94b07ffc8d0de428f552a

Change-Id: Ib1e324861b6a88e1a2f80e4f37a8afa654923a77
(cherry picked from commit e2bf4abee8)

Change-Id: I90cfb2549f4c7d630897aefc1c34aac6bac1e636
(cherry picked from commit 8bea6eb64d)

closes #1203

Change-Id: I6d4239e9ef5158a53e5e92a139d26a5b622f8aca
(cherry picked from commit 64de499865)

Change-Id: I3040a9631c1bfd2f0c30dffca4c1a7820afd9816
(cherry picked from commit e67e395a69)

Since dh_auto_test doesn't execute the test suites through make
directly, but instead runs `make -s -n` and then executes the output,
the integrated build tests fail since the sub-make doesn't return an
error as it should when attempting to build with the wrong .h
alternative, resulting in always the first .h alternative being used.
Fix this by using a wrapper script instead.

Also adjust some other related minor build details.

closes #1202

Change-Id: I4b6436295c6b39117bd06df53aa5afc7118ad6a1
(cherry picked from commit 52d9768418)

closes #1246

Change-Id: I5fc5ebd462589f0f585b8afce4908a6ac4a94bbb
(cherry picked from commit ec42f83353)

closes #1241

Change-Id: I698f57d1bc9fe77d8c95530beefbdb112165adfc
(cherry picked from commit dbf79cb762)

get_ssrc_ctx() returns a new reference to the SSRC object, therefore we
must release the referece when we're done with it.

Change-Id: I0db07e4cca49a37af68d072ac6d0630c025b8809
(cherry picked from commit 6527fb513c)

closes #1259

Change-Id: I0777647a8f6974fca845b4c35591bc7539f4891b
(cherry picked from commit 2057d0a367)

closes #1230

Change-Id: I26cae7b53eed1ff8155d2fa1e1aa5283a9c37d36
(cherry picked from commit e70d203802)
(cherry picked from commit 06d828c4a7)

Change-Id: Ie1a617c7ab82147dfce7973d927843f55906a1a5
(cherry picked from commit 80099bd57c)

The SSRC mapping strategy can change if a re-invite disengages
transcoding, therefore we always need to update the output SSRC mapping
even if the SSRC entry has already existed, to avoid stray SSRC changes.

Change-Id: Ib6f14ede1a4e615ff5eb8372cc68bf1acdd4b6c8
(cherry picked from commit dd7acd2644)

(cherry picked from commit bfe6d59693)
(cherry picked from commit b06c04bb87)

Change-Id: I172d09a2c9847c02841aeecfa7ca779e8f3dd623

closes #1243

Change-Id: Ib04c289ad78624139c0375423a7bc1ad402874e7
(cherry picked from commit 6cc1e99ee8)

Change-Id: I3085e67a81fb8adeeb4334db2e0e894716107937
(cherry picked from commit 89666c8021)

Change-Id: Id34d4fe31e58acfae31d8e5d30abec1837c4f808
(cherry picked from commit 5761e90722)

closes #1203

Change-Id: Ibc8cc89c8fe152a9dc3172d24d3c27b75463d9bd
(cherry picked from commit 1393dbfc9a)

closes #1203

Change-Id: I6e39d44aec1ae84595a6da30ab7ab365de4db9ad
(cherry picked from commit ff034ff307)

If we receive an SDP with a DTLS fingerprint, by default we adopt the
hash function used for that fingerprint in subsequent communication with
that peer. However, if the SDP is an answer, and we previously used a
different hash function in the offer towards that peer, then a later
re-invite offer would be sent with a different fingerprint, causing an
unexpected DTLS restart. Instead, make sure we don't change fingerprints
if one was already sent.

Change-Id: I603bb86ce2d7121556c161749ed08128dd0b63b2
(cherry picked from commit 8029a4d1cd)

Change-Id: I10689bc07b86984880bfd420d6be4fbb057c41d1
(cherry picked from commit def813cfde)

closes #1196

Change-Id: I08ec4bf783d2a6bc0e83498e61cf964718a03de4

Also set redis connected state when PING works again

Change-Id: Ifd8d1d774f55e7c58bf82c9a5f67787e02f53c3f

Change-Id: Ie4912bd5395802b51293d13c929a02374fa9b0f0

Change-Id: I0e60534d6d3cb62d25b8d865da02c3472cf0994e

Log an error and continue anyway if the send() failed, this is just
logging.

Change-Id: I542385489f8e37e6e524b766371fed3ba558ff2f

While these usages are not supposed to be security sensitive, it's still
best to avoid the usage altogether so that we do not need to think about
it. Add a taint macro so that this does not regress in the future.

Change-Id: Ic75861ed1b7ce9dfca4f897de8be2408204ce3cb
Warned-by: coverity

Change-Id: I27f9ca4f03cd979ecbcf01e8fb1801a306f9d396

fixes 8abc6b1c

Change-Id: Id38636308c9c6f37b95829911af71148ca3256ce

The dependency tracker is causing more problems than what it's worth, so
just remove it.

Change-Id: I5db8cae57400cd644add08447406a4526da03f65

Change-Id: I604bd76248aa0bc33589ee379a99b6f82c840662

Change-Id: I1aeb10662eac2ed0553cf4489d1e1d7a487ad272

__rtp_payload_type_add_recv takes ownership of `pt` and potentially
freeds it. Move the call to the end of the code block, after we're done
using it.

Change-Id: I5591cd6b22295ddcd6801e2bbbb381bff403fea8

closes #1185

Change-Id: I8cf6f4ff043649255dafa93b28fcb2127ce4d2bb

Avoid using an explicit test for the trickle ICE endpoint address and
instead use the TRICKLE_ICE flag.

Change-Id: I821ced7e77c798004c9d88ec072848b7f6e24a85

We should make sure total_secs is never 0.

Change-Id: I532c7d67a640b7f88ed6f7c0ff31189fe0d98fb0
Warned-by: coverity

Make the websocket_conn_init() function return an error code, and delay
the initialization after we cannot fail. And otherwise return -1, such
as when we cannot initialize the HTTP nor SSL connection.

Change-Id: I0facd53560fdb06678d7df9775be277e5c4b2cae
Warned-by: coverity

Change-Id: I6044cddc7d997848715df6701fd8a61a1e0bf289

The AUTO_CLEANUP_INIT() macro is already allocating a string for this
variable, which we were then overwriting and thus leaking.

Change-Id: If655c867c5666c6cff6311f01e617647375f6279
Warned-by: coverity

When open_memstream() fails, we should not try to write to it.

Change-Id: I9f92a1e1cc4aebe005039f28e5e3219e323e63c6
Warned-by: coverity

The __attempt_send() function will free the gs string on success,
so we should not free it again.

Change-Id: I74c9e41854db56bf29ae541eaeebfb97ce8eeb74
Warned-by: coverity

Change-Id: Ib7daeb3d838e0b679025f582f7c26fe5868f72cb

Change-Id: I64ec610b163534e3cfc0e7d0385329ab45c5cca3

Change-Id: I34e0aa0be1df06346e86684c6488caf8e302df9f

closes #1174

Change-Id: I277986ea30b25633c281291aa956fb2159c386ed

Change-Id: Ifb3ca589742a4ad0cc83982d6e42bf692a2c98db

also add better SDP error log output

closes #1182

Change-Id: I20ab77163a502793f63157fbafd0807c629a1ede

closes #1183

commit a74cf4a7f9
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Tue Feb 2 11:06:50 2021 +0100

    Add --dtmf-log-ng-tcp CLI option.

commit a428764d9b
Merge: 2bbfcb27 8abc6b1c
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Tue Feb 2 09:16:26 2021 +0100

    Merge branch 'master' into dtmf_events_over_ng_tcp

commit 2bbfcb2750
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Mon Feb 1 14:28:07 2021 +0100

    Replace hex values with chars.

commit dc1084d122
Merge: 2bce444b 2c7163ea
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Mon Feb 1 13:53:27 2021 +0100

    Merge branch 'dtmf_events_over_ng_tcp' of github.com:enreached/rtpengine into dtmf_events_over_ng_tcp

commit 2bce444b26
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Mon Feb 1 13:28:06 2021 +0100

    Prevent use after free.

commit 5a256fd3ae
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Fri Jan 29 13:30:31 2021 +0100

    Add missing includes.

commit a14f4034b9
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Fri Jan 29 13:27:27 2021 +0100

    Add support for sending DTMF events via protocol NG TCP.

commit b861fe3087
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Thu Jan 28 18:09:10 2021 +0100

    Add missing include.

commit 7bfe08fb08
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Thu Jan 28 18:05:44 2021 +0100

    Implementation of control-ng via TCP.

commit 2c7163eaf3
Merge: fd286813 9165bf1f
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Mon Feb 1 13:49:00 2021 +0100

    Merge branch 'dtmf_events_over_ng_tcp' of github.com:enreached/rtpengine into dtmf_events_over_ng_tcp

commit fd28681350
Author: Richard Fuchs <rfuchs@sipwise.com>
Date:   Fri Jan 29 10:20:02 2021 -0500

    TT#14008 fix AEAD kernel API for < 4.2

    Untested whether it actually works

    closes #1176

    Change-Id: If6398632ac62525a673b844cfb4ce842a8aa0346

commit 0626dcdd96
Author: Richard Fuchs <rfuchs@sipwise.com>
Date:   Fri Jan 29 13:07:25 2021 -0500

    TT#14008 improve log output for stray packets

    Change-Id: Ic4b03928b279aade761de3ba1646b5c27318e6a3

commit 8fcccb77cc
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Mon Feb 1 13:28:06 2021 +0100

    Prevent use after free.

commit f0d90d1831
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Fri Jan 29 13:30:31 2021 +0100

    Add missing includes.

commit 37462b8e4d
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Fri Jan 29 13:27:27 2021 +0100

    Add support for sending DTMF events via protocol NG TCP.

commit 9165bf1f75
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Mon Feb 1 13:28:06 2021 +0100

    Prevent use after free.

commit d616f2941f
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Fri Jan 29 13:30:31 2021 +0100

    Add missing includes.

commit bb063386c6
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Fri Jan 29 13:27:27 2021 +0100

    Add support for sending DTMF events via protocol NG TCP.

commit b28ab07532
Merge: 813a4f1c 6e4373af
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Fri Jan 29 09:21:31 2021 +0100

    Merge branch 'control_ng_tcp' of github.com:enreached/rtpengine into control_ng_tcp

commit 813a4f1caa
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Thu Jan 28 18:09:10 2021 +0100

    Add missing include.

commit 0c87a19c55
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Thu Jan 28 18:05:44 2021 +0100

    Implementation of control-ng via TCP.

commit 6e4373affb
Merge: fbf74bfe 7799f23a
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Fri Jan 29 09:19:46 2021 +0100

    Merge branch 'control_ng_tcp' of github.com:enreached/rtpengine into control_ng_tcp

commit fbf74bfe2d
Author: Richard Fuchs <rfuchs@sipwise.com>
Date:   Wed Jan 27 10:18:14 2021 -0500

    TT#14008 fix possible segfault

    closes #1172

    Change-Id: I94bb52c290c2032073e54528283660f03e694033

commit 1a5bcc0905
Author: Richard Fuchs <rfuchs@sipwise.com>
Date:   Thu Jan 28 14:49:43 2021 -0500

    TT#109251 fix redis restore segfault

    Change-Id: I501a47b065e7b8ff28a3ac157c0ce567f228557f

commit b38b49fd60
Author: Richard Fuchs <rfuchs@sipwise.com>
Date:   Thu Jan 28 13:44:44 2021 -0500

    TT#102450 added tests for Ia9fa96cf

    Change-Id: Ic9728e12a012335c30c5640ac0b5c88e39ad24ed

commit f33877bfe3
Author: Richard Fuchs <rfuchs@sipwise.com>
Date:   Thu Jan 28 13:43:46 2021 -0500

    TT#102450 fix some timestamping issues

    Make sure G.722 rate multiplies is applied in the right places

    Don't trust encoders to return proper timestamps, but instead track them
    explicitly based on frame duration

    Change-Id: Ia9fa96cf662da97159fa170c3a3f37516889e1bd

commit 39a25b954d
Author: Richard Fuchs <rfuchs@sipwise.com>
Date:   Thu Jan 28 14:07:53 2021 -0500

    TT#106101 mem leak fix for 554034eb7e

    Change-Id: I9c410211580d8513a203a29f898970a78175d08b

commit 11d11aed90
Author: Richard Fuchs <rfuchs@sipwise.com>
Date:   Thu Jan 28 13:41:28 2021 -0500

    TT#14008 clean up some tests

    Looks like packet order can be an issue in some cases

    Change-Id: Ib8fb8c553c9d0f2919b24dda1e15e5a23832c619

commit 7799f23aa5
Merge: ba7ee9d6 e191e16c
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Fri Jan 29 09:18:24 2021 +0100

    Merge branch 'master' of https://github.com/sipwise/rtpengine into control_ng_tcp

commit ba7ee9d6b1
Merge: f805d881 ffe187f1
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Thu Jan 28 18:15:58 2021 +0100

    Merge branch 'control_ng_tcp' of github.com:enreached/rtpengine into control_ng_tcp

commit f805d881fa
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Thu Jan 28 18:09:10 2021 +0100

    Add missing include.

commit c548a3ca4b
Author: Damir Nedžibović <damir.nedzibovic@enreach.com>
Date:   Thu Jan 28 18:05:44 2021 +0100

    Implementation of control-ng via TCP.

commit ffe187f116
Author: Damir Nedžibović <damir.nedzibovic@bad-team.net>
Date:   Thu Jan 28 18:05:44 2021 +0100

    Implementation of control-ng via TCP.

Change-Id: I8383fa80bce59aa865009e34caff5263b97ab588

Change-Id: Id1f464794089f4de4ffce4914703b588ef0045a3