Reorder the shutdown cleanup calls so that option strings are freed
last, as they may be used by other components during shutdown cleanup
Change-Id: I297f6d0c3dbbb22c4d34d7866844824c8d97e940
While these usages are not supposed to be security sensitive, it's still
best to avoid the usage altogether so that we do not need to think about
it. Add a taint macro so that this does not regress in the future.
Change-Id: Ic75861ed1b7ce9dfca4f897de8be2408204ce3cb
Warned-by: coverity
Rename test suites from *-test.c to test-*.c as the former is
conflicting with the file name pattern of the build tests, which are
listed in .gitignore.
Change-Id: I8779fac492510c0996bdcb2c6250c07536fe3b63
__rtp_payload_type_add_recv takes ownership of `pt` and potentially
freeds it. Move the call to the end of the code block, after we're done
using it.
Change-Id: I5591cd6b22295ddcd6801e2bbbb381bff403fea8
Avoid using an explicit test for the trickle ICE endpoint address and
instead use the TRICKLE_ICE flag.
Change-Id: I821ced7e77c798004c9d88ec072848b7f6e24a85
Make the websocket_conn_init() function return an error code, and delay
the initialization after we cannot fail. And otherwise return -1, such
as when we cannot initialize the HTTP nor SSL connection.
Change-Id: I0facd53560fdb06678d7df9775be277e5c4b2cae
Warned-by: coverity
Do not try to pass possibly negative values to malloc() calls that
do not expect them.
Change-Id: I20933983c26287cde5769e1594060b5a04eb09f6
Warned-by: coverity
We only do 1 decrements/increments so the check for the upper-bound will
always catch any downward wrap-around or an upward out-of-bound.
Change-Id: Ibdb9a69e1a55f34ffca56721c310efc505b86f99
Warned-by: coverity
The AUTO_CLEANUP_INIT() macro is already allocating a string for this
variable, which we were then overwriting and thus leaking.
Change-Id: If655c867c5666c6cff6311f01e617647375f6279
Warned-by: coverity
The dtmf_freqs array contains one less element than the check was
allowing for.
Change-Id: I783fa6bcd0bd79fad9886ee53e7a990e504ecff8
Warned-by: coverity
The __attempt_send() function will free the gs string on success,
so we should not free it again.
Change-Id: I74c9e41854db56bf29ae541eaeebfb97ce8eeb74
Warned-by: coverity
When we disable transcoding we should completely disable building the
rtpengine-recording daemon packages too. We accomplish that by using a
build-profile.
This also removes the Debianism from the upstream build system and moves
the setting to the Debian packaging.
Change-Id: Idf7783823d36b49ce03610fb1f4386afe5887029
Richard Fuchs
Stefan Mititelu
Sipwise Jenkins Builder
Guillem Jover