rtpengine

1.5 GiB

Tree: 378e69944f

Author	SHA1	Message	Date
Sewan R&D	6fd79f5206	feat: notify-purge removes a file if notify success Closes #1675 Change-Id: I5edd20efabcf94a19932a7066e80d77e6d99f0d2	3 years ago
Donat Zenichev	de0e31eaeb	MT#56493 Fix some defects discovered by CoverityScan Fix the following defect: *** CID 1534609: (DEADCODE) /recording-daemon/notify.c: 110 in do_notify() 104 part = curl_mime_addpart(mime); 105 curl_mime_name(part, "ngfile"); 106 if (ret != CURLE_OK) 107 goto fail; 108 curl_mime_filedata(part, req->full_filename_path); 109 if (ret != CURLE_OK) >>> CID 1534609: (DEADCODE) >>> Execution cannot reach this statement: "goto fail;". 110 goto fail; 111 curl_easy_setopt(c, CURLOPT_MIMEPOST, mime); 112 if (ret != CURLE_OK) 113 goto fail; 114 } 115 /recording-daemon/notify.c: 113 in do_notify() 107 goto fail; 108 curl_mime_filedata(part, req->full_filename_path); 109 if (ret != CURLE_OK) 110 goto fail; 111 curl_easy_setopt(c, CURLOPT_MIMEPOST, mime); 112 if (ret != CURLE_OK) >>> CID 1534609: (DEADCODE) >>> Execution cannot reach this statement: "goto fail;". 113 goto fail; 114 } 115 116 err = "performing request"; 117 ret = curl_easy_perform(c); 118 if (ret != CURLE_OK) /recording-daemon/notify.c: 107 in do_notify() 101 err = "initializing curl mime&part"; 102 curl_mimepart part; 103 mime = curl_mime_init(c); 104 part = curl_mime_addpart(mime); 105 curl_mime_name(part, "ngfile"); 106 if (ret != CURLE_OK) >>> CID 1534609: (DEADCODE) >>> Execution cannot reach this statement: "goto fail;". 107 goto fail; 108 curl_mime_filedata(part, req->full_filename_path); 109 if (ret != CURLE_OK) 110 goto fail; 111 curl_easy_setopt(c, CURLOPT_MIMEPOST, mime); 112 if (ret != CURLE_OK) ** CID 1534608: Error handling issues (CHECKED_RETURN) /recording-daemon/notify.c: 108 in do_notify() 102 curl_mimepart part; 103 mime = curl_mime_init(c); 104 part = curl_mime_addpart(mime); 105 curl_mime_name(part, "ngfile"); 106 if (ret != CURLE_OK) 107 goto fail; >>> CID 1534608: Error handling issues (CHECKED_RETURN) >>> Calling "curl_mime_filedata(part, req->full_filename_path)" without checking return value. >>> This library function may fail and return an error code. 108 curl_mime_filedata(part, req->full_filename_path); 109 if (ret != CURLE_OK) 110 goto fail; 111 curl_easy_setopt(c, CURLOPT_MIMEPOST, mime); 112 if (ret != CURLE_OK) 113 goto fail; ** CID 1534607: Error handling issues (CHECKED_RETURN) /recording-daemon/notify.c: 111 in do_notify() 105 curl_mime_name(part, "ngfile"); 106 if (ret != CURLE_OK) 107 goto fail; 108 curl_mime_filedata(part, req->full_filename_path); 109 if (ret != CURLE_OK) 110 goto fail; >>> CID 1534607: Error handling issues (CHECKED_RETURN) >>> Calling "curl_easy_setopt(c, _curl_opt, mime)" without checking return value. >>> This library function may fail and return an error code. 111 curl_easy_setopt(c, CURLOPT_MIMEPOST, mime); 112 if (ret != CURLE_OK) 113 goto fail; 114 } 115 116 err = "performing request"; Additionally, refactor the code in the do_notify() slightly. Change-Id: I80dd373f4ced92d90475dbcca21ee2d62f06e57e	3 years ago
Richard Fuchs	aa0ccae1d7	MT#55283 fix compilation for older libcurl Debian stretch has an old libcurl which doesn't support MIMEPOST. Disable the entire feature if libcurl is too old. Change-Id: Id1d2a4d821671142523af355188f21ff06ad20f1	3 years ago
Serdar GÜÇLÜER	a75d55444b	MT#55283 Support attaching recorded file closes #1611 Change-Id: Id03400fb79339f4b0ed1eddfd6dce56295e57cef	3 years ago
Richard Fuchs	ff47e874ea	MT#56493 add support for HTTP notifications Change-Id: I3ac04968279a5b750f1f7f4d4d06207e05e7d8a8	3 years ago

5 Commits (378e69944f70b89e13f8f09941d0eeedda3424eb)