Complete overhaul of the codec handling code:
*) obsolete flags `asymmetric codecs`, `symmetric codecs`, `reorder
codecs`
*) support proper codec offer/answer
*) split codec manipulation (strip/offer/accept/etc) into separate
functions for clarity and better code maintenance
*) fully update codec handlers in both directions after an answer
*) explicit allocation and handling of codecs and payload types in a
codec_store object
*) improve codec matchup logic during answer
*) more explicit handling of supplemental codecs (CN/DTMF)
*) remove now obsolete hacks for handling certain use cases
Change-Id: I996705ba8fe339524c2f70e6bb0fd854f9a1f4fb
This solves problems when the same SSRC is looped through the same call
multiple times in different mono/dialogues, with different parameters.
Change-Id: I1d033cb1f012574d82b5bcbfffe11eb5f983cfd8
Transcoding should not be decided based on the name of the codec alone,
but primarily on the payload type. First the PT needs to be compared,
then the codec type must be confirmed.
closes#1289
Change-Id: I1a8bffc6d521443aba14d9b4cf1ad4d1e21f1226
commit 26478c1dcf
Merge: aeb0b7bcfc265e0b
Author: Richard Fuchs <rfuchs@sipwise.com>
Date: Wed Jun 23 14:45:32 2021 -0400
Merge branch 'el-systemd' of https://github.com/khorsmann/rtpengine into khorsmann-el-systemd
Change-Id: Ide2e93d5baa1ecba97d256a48c53c106c084f9fd
commit fc265e0b3d
Merge: 41a9a8ae1d845c21
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Wed Jun 23 19:25:09 2021 +0200
Merge branch 'sipwise:master' into el-systemd
commit 41a9a8ae6e
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Wed Jun 23 19:22:09 2021 +0200
iptables in ExecStart/ExecStopPost needs root privleges. Correct copy-paste error.
commit 0f991f6666
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Wed Jun 23 17:57:55 2021 +0200
readd User/Group and switch back to forking cause CentOS7 systemd is very old
commit 11290d48b6
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Tue Jun 22 12:18:38 2021 +0200
if ngcp-virt-identify not there should not break the script
commit b7040ad992
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Tue Jun 22 12:05:04 2021 +0200
add iptables helper for el systemd to spec file
commit 6d67dc3b3a
Author: Karsten Horsmann <khorsmann@gmail.com>
Date: Tue Jun 22 11:21:34 2021 +0200
* add also ngcp-rtpengine-iptables-setup. So iptables rules will created like the debian packages did that.
closes#1292
Change-Id: I6f31608c70b069b3584ad240b7eda10e59c94e4b
The JSON context is already in an object, therefore skip the surrounding
{} enclosure.
Also don't run the global MQTT timer when MQTT is disabled.
closes#1290
Change-Id: I63c622bd339545e625ee18def33f21de2533f949
Recent builds fail with
Run sudo apt-get build-dep -qq -y -Ppkg.ngcp-rtpengine.nobcg729 .
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/s/systemd/libsystemd-dev_245.4-4ubuntu3.6_amd64.deb 404 Not Found [IP: 52.154.174.208 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
E: Failed to process build dependencies
Change-Id: If7d4d0be41bbc93b7e131fd1e68094a9a374a6f2
Systemd complains about 755 rights of EL service files.
"systemd[1]: Configuration file /usr/lib/systemd/system/rtpengine.service is marked executable. Please remove executable permission bits. Proceeding anyway."
The only reason the wait time in timer threads is capped at 100 ms is to
catch the daemon's shutdown. Since these threads already use a
condition variable to be woken up, we can use the same condition to wake
up the threads during a shutdown, allowing for a much longer (possibly
unlimited) sleep time in timer threads.
Change-Id: I3b5f280a4d502176a731e8b52b1b731022c8db4f
When a new timer object is scheduled to run in the future, we only need
to wake up one thread to notify about the new object as only one thread
is needed to handle it. The other threads can remain in the previous
sleep state.
Change-Id: I92ccec61a6c5a4a3cea5c5428c85f83707cf4d64
GLib 2.68 deprecates g_memdup() in favour of g_memdup2() as the former
was using a guint second argument which could lead to integer overflows
(gsize should be used instead).
Change-Id: Iaa3e3b1ecaab00d1ac887c915397b15b7204dd11
This makes sure all objects are cleaned up during shutdown even if the
respective timer hasn't run yet.
Change-Id: I197b930f1b6e407819cc5a8c4ebd92fcef21b2cd
Some codec handlers hold references to objects held within the
statistics hash table, therefore we must free the statistics after all
codec handlers have been released.
Change-Id: I3832dbeeaaf21d4a82be2dc2c842718415fd46f7
Recent ffmpeg versions have removed AVPacket from the public ABI,
therefore deprecating av_init_packet on statically allocated objects.
The replacement is av_packet_alloc()/av_packet_free().
Change-Id: I5f93fbd19e43413c3328e143cc9147fbdf12d910
Richard Fuchs
Karsten Horsmann
Nathanaël Semhoun
Sipwise Jenkins Builder