If we are creating the kernel forwarding table, we have to make sure it
has been deleted already, otherwise we can get into collisions with the
already setup forwardings, and the subsequent add will fail anyway.
Change-Id: I2601c602543ff3e3493bae296d263dde545ff352
We should preserve the errno value so that the caller can report
accurate error information, as the close() call could fail too.
Change-Id: I1a36ace8f47ad3ea550aa3e2e272922633abfdca
- Add missing quotes.
- Switch some problematic usages to use bash arrays.
- Override shellcheck errors (these might need fixing in the future).
Change-Id: Id451ff9f4c5d5ef9b3826544908d64e9c08c5797
Even though this is a false-positive, it confuses checkbashisms. So
let's rename the variables to something else, even more descriptive,
to avoid the check error.
Change-Id: Ife79bf76121bb4e3c120525ffe5a0eca871936f6
The code is correct, but perlcritic seems to have problems parsing it
and confuses it with a statement separated with a comma.
Change-Id: I76cd82699cffa2b1a9d938c53172f02d09f47583
These are methods and do not really conflict with the perl builtins
with the same name outside of this package.
Change-Id: If7405ebc6a9e862433e576743ae6c32d7d6ec51e
While these instances are a bit pointless as they are assigned on the
file scope, and this is something that should be allowed by perlcritic.
Let's just do this, which does no harm, so that we can catch other
problematic cases.
Change-Id: I674b1374a62fa976e20a3fedf356ae6d4848a796
These variables have magic meanings, we should avoid their usage to not
confuse readers nor trigger side-effects.
Change-Id: Ieb759f74ccde6ba6466f5c02743e3f881b5d53b7
Using sort on a scalar context has undefined behavior. Assign the result
of the sort into an array and return that.
Change-Id: I180ba1dfcafe6e49132a38bd01be715718a4dff1
- Use autoflush method per filehandle instead of setting $| and using
the one argument select().
- Use lexical variables instead of barewords for filehandles.
Change-Id: Icd71248a28bea0974a79e489add5deee0b65748d
Fixes garbled audio for certain codes (e.g. G.729)
Also adds some additional debug output
Fixes#410
Change-Id: I1dbae2638f1e55bf80bb96549a75b9c4b82d08bf
make sure not to run with a single thread if only one CPU core is
present
proper fix pending: convert CLI code to non-blocking, muxed, using
streambuf interface
closes#399
Change-Id: I09a6d758c668fe6a2bbe6735e3299d3c8cb1ba58