From 80efc45120d9d9f802d5c8b3a38dcd4190441c18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guillermo=20Guti=C3=A9rrez?= Date: Wed, 16 Jan 2019 08:39:05 -0600 Subject: [PATCH] UI-3286: Set default option on select main extension pop-up (#115) --- submodules/users/users.js | 15 ++++----------- submodules/users/views/changePresenceIDPopup.html | 8 ++++---- 2 files changed, 8 insertions(+), 15 deletions(-) diff --git a/submodules/users/users.js b/submodules/users/users.js index d0f23be..16f14b3 100644 --- a/submodules/users/users.js +++ b/submodules/users/users.js @@ -1831,20 +1831,13 @@ define(function(require) { var self = this; if (user.presence_id) { - var found = false, - formattedPresenceID = '' + user.presence_id; + var formattedPresenceID = '' + user.presence_id; - _.each(listNumbers, function(number) { - if (number === formattedPresenceID) { - found = true; - } + return _.some(listNumbers, function(number) { + return number === formattedPresenceID; }); - - return found; - } else if (listNumbers.length) { - return false; } else { - return true; + return _.isEmpty(listNumbers); } }, diff --git a/submodules/users/views/changePresenceIDPopup.html b/submodules/users/views/changePresenceIDPopup.html index cf34e47..1eec87c 100644 --- a/submodules/users/views/changePresenceIDPopup.html +++ b/submodules/users/views/changePresenceIDPopup.html @@ -4,10 +4,10 @@
- {{#each numbers}} -
{{ formatPhoneNumber this }}
+ {{#each numbers}} +
{{ formatPhoneNumber this }}
{{/each}} -
+
{{ i18n.users.presenceIDPopup.none}}
@@ -18,4 +18,4 @@
- \ No newline at end of file +