From 8608ea718be8df4a8a3db50516688375cf60853a Mon Sep 17 00:00:00 2001
From: Joris Tirado <joris@tirado.com>
Date: Tue, 25 Apr 2017 16:30:11 -0700
Subject: [PATCH] UI-2704: Return `null` for unset keys (#25)

---
 submodules/devices/devices.js | 22 +++++++++++-----------
 views/devices-sip_device.html |  6 ------
 2 files changed, 11 insertions(+), 17 deletions(-)

diff --git a/submodules/devices/devices.js b/submodules/devices/devices.js
index 2fb87f4..a46c7b2 100644
--- a/submodules/devices/devices.js
+++ b/submodules/devices/devices.js
@@ -324,14 +324,16 @@ define(function(require) {
 					var section = '.tabs-section[data-section="' + value.type + '"] ';
 
 					_.each(value.data, function(val, key) {
-						var groupSelector = '.control-group[data-id="' + key + '"] ',
-							valueSelector = '.feature-key-value[data-type="' + val.type + '"]';
-
-						templateDevice
-							.find(section.concat(groupSelector, valueSelector))
-								.addClass('active')
-							.find('[name="provision.keys.' + value.id + '[' + key + '].value"]')
-								.val(val.value);
+						if (val) {
+							var groupSelector = '.control-group[data-id="' + key + '"] ',
+								valueSelector = '.feature-key-value[data-type="' + val.type + '"]';
+
+							templateDevice
+								.find(section.concat(groupSelector, valueSelector))
+									.addClass('active')
+								.find('[name="provision.keys.' + value.id + '[' + key + '].value"]')
+									.val(val.value);
+						}
 					});
 				});
 
@@ -665,9 +667,7 @@ define(function(require) {
 					var keys = {};
 
 					list[key].forEach(function(val, idx) {
-						if (val.type !== 'none') {
-							keys[idx] = val;
-						}
+						keys[idx] = val.type === 'none' ? null : val;
 					});
 
 					if (_.isEmpty(keys)) {
diff --git a/views/devices-sip_device.html b/views/devices-sip_device.html
index 17c8787..7308062 100644
--- a/views/devices-sip_device.html
+++ b/views/devices-sip_device.html
@@ -347,12 +347,6 @@
 							<label for="provision.keys.{{../id}}[{{@key}}].value">{{ @root.i18n.devices.popupSettings.keys.labels.value }}</label>
 							<input type="text" value="" name="provision.keys.{{../id}}[{{@key}}].value">
 						</div>
-					{{#compare id '===' 'combo_keys'}}
-						{{#compare @key '===' '0'}}
-							{{#if @root.extra.firstComboKeyUnset}}
-							{{/if}}
-						{{/compare}}
-					{{/compare}}
 					</div>
 				</div>
 				{{/each}}