Browse Source

UI-3269-fixes: Fix form submit and improve device form validations (#112)

* Move buttons aout to prevent form submit

* Add device form validations
4.3
Ricardo Merino 7 years ago
committed by GitHub
parent
commit
9f923c135c
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 14 deletions
  1. +16
    -6
      submodules/users/users.js
  2. +7
    -8
      submodules/users/views/creation.html

+ 16
- 6
submodules/users/users.js View File

@ -1775,6 +1775,12 @@ define(function(require) {
},
'user.password': {
minlength: 6
},
'user.device.name': 'required',
'user.device.model': 'required',
'user.device.mac_address': {
required: true,
mac: true
}
},
messages: {
@ -1786,6 +1792,15 @@ define(function(require) {
},
'callflow.extension': {
required: self.i18n.active().validation.required
},
'user.device.model': {
required: self.i18n.active().validation.required
},
'user.device.name': {
required: self.i18n.active().validation.required
},
'user.device.mac_address': {
required: self.i18n.active().validation.required
}
}
};
@ -3834,12 +3849,7 @@ define(function(require) {
delete formattedData.user.extra;
if (
_.get(data, 'user.device.brand', 'none') === 'none'
&& _.get(data, 'user.device.model', 'none') === 'none'
&& _.isEmpty(_.get(data, 'user.device.name'))
&& _.isEmpty(_.get(data, 'user.device.mac_address'))
) {
if (_.get(data, 'user.device.brand', 'none') === 'none') {
delete formattedData.user.device;
return formattedData;
}


+ 7
- 8
submodules/users/views/creation.html View File

@ -121,16 +121,15 @@
</div>
<div class="span6 device-mac to-right">
<label for="mac_address" class="control-label">{{ i18n.users.dialogCreationUser.addDevice.macAddress }}</label>
<input required type="text" id="mac_address" name="user.device.mac_address" placeholder="19:33:1A:B2:12:58">
</div>
</div>
<div>
<div class="dialog-buttons-wrapper add-user-actions">
<button class="monster-button monster-button-success create_user">{{ i18n.users.dialogCreationUser.createUser }}</button>
<button class="monster-button monster-button-success create_user" data-action="add_new">{{ i18n.users.dialogCreationUser.createUserAndAddAnother }}</button>
<input type="text" id="mac_address" name="user.device.mac_address" placeholder="19:33:1A:B2:12:58">
</div>
</div>
</form>
<div>
<div class="dialog-buttons-wrapper add-user-actions">
<button class="monster-button monster-button-success create_user">{{ i18n.users.dialogCreationUser.createUser }}</button>
<button class="monster-button monster-button-success create_user" data-action="add_new">{{ i18n.users.dialogCreationUser.createUserAndAddAnother }}</button>
</div>
</div>
</div>

Loading…
Cancel
Save