From d283b1a15669830ea7d5706fbefde7616182145f Mon Sep 17 00:00:00 2001 From: Joris Tirado Date: Thu, 12 Nov 2015 16:04:22 -0800 Subject: [PATCH] UI-1856: On Users tab, hide cnam feature when disabled on the account --- submodules/users/users.js | 49 ++++++++++++++++++--------------- views/users-numbers.html | 4 ++- views/users-numbersItemRow.html | 4 ++- 3 files changed, 33 insertions(+), 24 deletions(-) diff --git a/submodules/users/users.js b/submodules/users/users.js index dad98a6..4e38349 100644 --- a/submodules/users/users.js +++ b/submodules/users/users.js @@ -1054,6 +1054,7 @@ define(function(require){ template .find('.list-assigned-items') .append($(monster.template(self, 'users-numbersItemRow', { + isCnamEnabled: monster.util.isNumberFeatureEnabled('cnam'), isE911Enabled: monster.util.isNumberFeatureEnabled('e911'), number: val }))); @@ -1085,6 +1086,7 @@ define(function(require){ number.phoneNumber = number.id; var rowTemplate = $(monster.template(self, 'users-numbersItemRow', { + isCnamEnabled: monster.util.isNumberFeatureEnabled('cnam'), isE911Enabled: monster.util.isNumberFeatureEnabled('e911'), number: number })); @@ -1143,33 +1145,35 @@ define(function(require){ } }); - template.on('click', '.callerId-number', function() { - var cnamCell = $(this).parents('.item-row').first(), - phoneNumber = cnamCell.data('id'); + if (monster.util.isNumberFeatureEnabled('cnam')) { + template.on('click', '.callerId-number', function() { + var cnamCell = $(this).parents('.item-row').first(), + phoneNumber = cnamCell.data('id'); - if(phoneNumber) { - var args = { - phoneNumber: phoneNumber, - callbacks: { - success: function(data) { - if('cnam' in data.data && data.data.cnam.display_name) { - cnamCell.find('.features i.feature-outbound_cnam').addClass('active'); - } else { - cnamCell.find('.features i.feature-outbound_cnam').removeClass('active'); - } + if(phoneNumber) { + var args = { + phoneNumber: phoneNumber, + callbacks: { + success: function(data) { + if('cnam' in data.data && data.data.cnam.display_name) { + cnamCell.find('.features i.feature-outbound_cnam').addClass('active'); + } else { + cnamCell.find('.features i.feature-outbound_cnam').removeClass('active'); + } - if('cnam' in data.data && data.data.cnam.inbound_lookup) { - cnamCell.find('.features i.feature-inbound_cnam').addClass('active'); - } else { - cnamCell.find('.features i.feature-inbound_cnam').removeClass('active'); + if('cnam' in data.data && data.data.cnam.inbound_lookup) { + cnamCell.find('.features i.feature-inbound_cnam').addClass('active'); + } else { + cnamCell.find('.features i.feature-inbound_cnam').removeClass('active'); + } } } - } - }; + }; - monster.pub('common.callerId.renderPopup', args); - } - }); + monster.pub('common.callerId.renderPopup', args); + } + }); + } if (monster.util.isNumberFeatureEnabled('e911')) { template.on('click', '.e911-number', function() { @@ -2618,6 +2622,7 @@ define(function(require){ self.usersGetNumbersData(userId, function(results) { self.usersFormatNumbersData(userId, results, function(results) { template = $(monster.template(self, 'users-numbers', $.extend(true, {}, results, { + isCnamEnabled: monster.util.isNumberFeatureEnabled('cnam'), isE911Enabled: monster.util.isNumberFeatureEnabled('e911') }))); diff --git a/views/users-numbers.html b/views/users-numbers.html index 0e02f27..130a39e 100644 --- a/views/users-numbers.html +++ b/views/users-numbers.html @@ -14,7 +14,9 @@