Browse Source

Avoid unnecessary copies of PhoneMetadata

The PhoneMetadata can be moved into the hashmap avoiding a copy.
pull/3300/head
sopwithcamel 2 years ago
committed by GitHub
parent
commit
02fe055035
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
  1. +3
    -3
      cpp/src/phonenumbers/shortnumberinfo.cc

+ 3
- 3
cpp/src/phonenumbers/shortnumberinfo.cc View File

@ -52,9 +52,9 @@ ShortNumberInfo::ShortNumberInfo()
LOG(DFATAL) << "Could not parse compiled-in metadata.";
return;
}
for (const auto& metadata : metadata_collection.metadata()) {
const string& region_code = metadata.id();
region_to_short_metadata_map_->insert(std::make_pair(region_code, metadata));
for (auto& metadata : *(metadata_collection.mutable_metadata())) {
const string region_code = metadata.id();
region_to_short_metadata_map_->emplace(region_code, std::move(metadata));
}
regions_where_emergency_numbers_must_be_exact_->insert("BR");
regions_where_emergency_numbers_must_be_exact_->insert("CL");


Loading…
Cancel
Save