Browse Source

Update ShortNumberInfo test regarding example number change. (#2268)

* Update ShortNumberInfo test regarding example number change for region AM. Unlike PhoneNumberUtilTest, ShortNumberInfoTest uses real metadata for unit testing.

* Changing the region as Travis tests do not pass with old short metadata of AM

* Making same changes in CPP and JS
pull/2269/head
penmetsaa 7 years ago
committed by GitHub
parent
commit
03e2a0b314
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
  1. +1
    -1
      cpp/test/phonenumbers/shortnumberinfo_test.cc
  2. +1
    -1
      java/libphonenumber/test/com/google/i18n/phonenumbers/ShortNumberInfoTest.java
  3. +1
    -1
      javascript/i18n/phonenumbers/shortnumberinfo_test.js

+ 1
- 1
cpp/test/phonenumbers/shortnumberinfo_test.cc View File

@ -299,7 +299,7 @@ TEST_F(ShortNumberInfoTest, GetExpectedCostForSharedCountryCallingCode) {
} }
TEST_F(ShortNumberInfoTest, GetExampleShortNumber) { TEST_F(ShortNumberInfoTest, GetExampleShortNumber) {
EXPECT_EQ("8711", short_info_.GetExampleShortNumber(RegionCode::AM()));
EXPECT_EQ("110", short_info_.GetExampleShortNumber(RegionCode::AD()));
EXPECT_EQ("1010", short_info_.GetExampleShortNumber(RegionCode::FR())); EXPECT_EQ("1010", short_info_.GetExampleShortNumber(RegionCode::FR()));
EXPECT_EQ("", short_info_.GetExampleShortNumber(RegionCode::UN001())); EXPECT_EQ("", short_info_.GetExampleShortNumber(RegionCode::UN001()));
EXPECT_EQ("", short_info_.GetExampleShortNumber(RegionCode::GetUnknown())); EXPECT_EQ("", short_info_.GetExampleShortNumber(RegionCode::GetUnknown()));


+ 1
- 1
java/libphonenumber/test/com/google/i18n/phonenumbers/ShortNumberInfoTest.java View File

@ -195,7 +195,7 @@ public class ShortNumberInfoTest extends TestMetadataTestCase {
} }
public void testGetExampleShortNumber() { public void testGetExampleShortNumber() {
assertEquals("8711", shortInfo.getExampleShortNumber(RegionCode.AM));
assertEquals("110", shortInfo.getExampleShortNumber(RegionCode.AD));
assertEquals("1010", shortInfo.getExampleShortNumber(RegionCode.FR)); assertEquals("1010", shortInfo.getExampleShortNumber(RegionCode.FR));
assertEquals("", shortInfo.getExampleShortNumber(RegionCode.UN001)); assertEquals("", shortInfo.getExampleShortNumber(RegionCode.UN001));
assertEquals("", shortInfo.getExampleShortNumber(null)); assertEquals("", shortInfo.getExampleShortNumber(null));


+ 1
- 1
javascript/i18n/phonenumbers/shortnumberinfo_test.js View File

@ -271,7 +271,7 @@ function testGetExpectedCostForSharedCountryCallingCode() {
} }
function testGetExampleShortNumber() { function testGetExampleShortNumber() {
assertEquals('8711', shortInfo.getExampleShortNumber(RegionCode.AM));
assertEquals('110', shortInfo.getExampleShortNumber(RegionCode.AD));
assertEquals('1010', shortInfo.getExampleShortNumber(RegionCode.FR)); assertEquals('1010', shortInfo.getExampleShortNumber(RegionCode.FR));
assertEquals('', shortInfo.getExampleShortNumber(RegionCode.UN001)); assertEquals('', shortInfo.getExampleShortNumber(RegionCode.UN001));
assertEquals('', shortInfo.getExampleShortNumber(null)); assertEquals('', shortInfo.getExampleShortNumber(null));


Loading…
Cancel
Save