Browse Source

Update Visual Studio documentation (#1597)

pull/1537/merge
Keghani Kouzoujian 9 years ago
committed by GitHub
parent
commit
ab5df263eb
2 changed files with 18 additions and 0 deletions
  1. +2
    -0
      FAQ.md
  2. +16
    -0
      cpp/README

+ 2
- 0
FAQ.md View File

@ -287,6 +287,8 @@ contribute a PR and/or review and test out someone else's PR, please chime in on
these links, or email the [discussion
group](https://groups.google.com/group/libphonenumber-discuss):
* [#1010](https://github.com/googlei18n/libphonenumber/issues/1010) to require
Visual Studio 2015 update 2 or later on Windows
* PR [#1090](https://github.com/googlei18n/libphonenumber/pull/1090) /
[#824](https://github.com/googlei18n/libphonenumber/issues/824) to "Replace
POSIX directory operations by Boost Filesystem"


+ 16
- 0
cpp/README View File

@ -263,6 +263,22 @@ Troubleshooting CMake via ccmake
Building the library on Windows (Visual Studio)
-----------------------------------------------
We recommend that libphonenumber on Windows be built with Visual Studio 2015
Update 2 (https://www.visualstudio.com/en-us/news/releasenotes/vs2015-update2-vs)
or later.
This enables support of plain UTF-8 source files, for which you also need to specify
the /utf-8 option in build files; see "New Options in VS2015 Update 2" at
https://blogs.msdn.microsoft.com/vcblog/2016/02/22/new-options-for-managing-character-sets-in-the-microsoft-cc-compiler/,
or a Chrome patch for an example:
https://codereview.chromium.org/2488853002/diff/80001/build/config/compiler/BUILD.gn
Without this version and the option, your compilation will have warnings when
setting the codepage for non-Unicode applications on Windows to one of the CJK
code pages, since libphonenumber has UTF-8 strings in source files. While these
are only comments (as opposed to string literals) the warnings can be
suppressed, but we reserve the right to introduce UTF-8 string literals.
The library was tested with Visual Studio 2010.
You will need to manually fetch and install the following dependencies:


Loading…
Cancel
Save