1) Changing the BuildMetadataFromXml to only set
same_mobile_and_fixed_line_pattern and
national_prefix_optional_when_formatting if they differ from default
values, and the domestic_carrier_code_formatting_rule,
international_prefix and national_prefix_formatting_rule if there is
one.
2) Adding a test with some golden data for the BuildMetadataJsonFromXml.
3) Adding to the proto a missing explicit default false.
4) Updating a couple of methods in the Phonemetadata.java class to have
names that match those of the auto-generated Phonemetadata used by the
CPP build, now that we use those methods when building the metadata.
5) Fix to ant build file to enable the junit command to still work (instructions on open-source on how to regenerate metadata files refer to this)
Resulting data is smaller for Java and C++ and the resulting BuildMetadataJsonFromXml code is cleaner.
This CL (depending on CL 5376090) adds the Maven support for the offline phone number geocoder.
All the geocoding-related code/data is moved to the new directory java/geocoder.
Additionally a pom.xml file is added to java/ and java/geocoder/.
The pom.xml file located in java/ is the parent pom file which contains the configuration (SCM, developers, encoding...) that applies to both the libphonenumber and geocoder modules.
The libphonenumber and geocoder Maven modules inherit from this parent pom file therefore they don't need to duplicate this configuration.
I also moved build.xml and release_notes.txt back to java/.
BUG=57
Review URL: http://codereview.appspot.com/5395054
PhoneNumberUtil.resetInstance() should always be used instead. This omission should not be hidden by unit tests that fork.
That also makes the external version consistent with the internal one in which unit tests don't seem to be executed by default in isolated processes.
Review URL: http://codereview.appspot.com/5341042