Browse Source

use super for supports base case, remove unused `data_for`.

pull/668/head
Ross McFarland 5 years ago
committed by GitHub
parent
commit
55af09d73c
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
  1. +1
    -2
      octodns/provider/dnsimple.py
  2. +1
    -1
      octodns/provider/dnsmadeeasy.py

+ 1
- 2
octodns/provider/dnsimple.py View File

@ -280,7 +280,6 @@ class DnsimpleProvider(BaseProvider):
values = defaultdict(lambda: defaultdict(list)) values = defaultdict(lambda: defaultdict(list))
for record in self.zone_records(zone): for record in self.zone_records(zone):
_type = record['type'] _type = record['type']
data_for = getattr(self, '_data_for_{}'.format(_type), None)
if _type not in self.SUPPORTS: if _type not in self.SUPPORTS:
self.log.warning( self.log.warning(
'populate: skipping unsupported %s record', 'populate: skipping unsupported %s record',
@ -325,7 +324,7 @@ class DnsimpleProvider(BaseProvider):
) )
return False return False
return record._type in self.SUPPORTS
return super(DnsimpleProvider, self).supports(record)
def _params_for_multiple(self, record): def _params_for_multiple(self, record):
for value in record.values: for value in record.values:


+ 1
- 1
octodns/provider/dnsmadeeasy.py View File

@ -306,7 +306,7 @@ class DnsMadeEasyProvider(BaseProvider):
) )
return False return False
return record._type in self.SUPPORTS
return super(DnsMadeEasyProvider, self).supports(record)
def _params_for_multiple(self, record): def _params_for_multiple(self, record):
for value in record.values: for value in record.values:


Loading…
Cancel
Save