Browse Source

Added test for missing zone file

pull/1125/head
Alizey Jalil 2 years ago
parent
commit
c816fe7af0
4 changed files with 20 additions and 0 deletions
  1. BIN
      .DS_Store
  2. +5
    -0
      octodns/manager.py
  3. +10
    -0
      tests/config/missing-zone-config.yaml
  4. +5
    -0
      tests/test_octodns_manager.py

BIN
.DS_Store View File


+ 5
- 0
octodns/manager.py View File

@ -600,7 +600,12 @@ class Manager(object):
aliased_zones = {}
delayed_arpa = []
futures = []
for zone_name, config in zones.items():
if config is None:
raise ManagerException(
f'Passed zone: {zone_name} not found in config'
)
decoded_zone_name = idna_decode(zone_name)
self.log.info('sync: zone=%s', decoded_zone_name)
if 'alias' in config:


+ 10
- 0
tests/config/missing-zone-config.yaml View File

@ -0,0 +1,10 @@
manager:
max_workers: 2
providers:
in:
class: octodns.provider.yaml.YamlProvider
directory: tests/config
dump:
class: octodns.provider.yaml.YamlProvider
directory: env/YAML_TMP_DIR
zones: {}

+ 5
- 0
tests/test_octodns_manager.py View File

@ -79,6 +79,11 @@ class TestManager(TestCase):
)
self.assertTrue('missing sources' in str(ctx.exception))
def test_missing_zone(self):
with self.assertRaises(ManagerException) as ctx:
Manager(get_config_filename('missing-zone-config.yaml')).sync()
self.assertTrue('Passed zone:' in str(ctx.exception))
def test_missing_targets(self):
with self.assertRaises(ManagerException) as ctx:
Manager(get_config_filename('provider-problems.yaml')).sync(


Loading…
Cancel
Save