Creating the codec handler can possibly fail. Catch that case.

Closes #1693

Change-Id: Iebd8d1c6aa3542cd9e1351756148c48ebada38ec
(cherry picked from commit 94ba3e0fa8)

... stream after a reconnect

if we're in the middle of a disconnect then ssrc_tls_state may have destroyed
the streambuf so we need to skip the rest of the function, otherwise the now
null pointer is passed into streambuf_write, which will return immediately and
the metadata will have been marked as sent when it hasn't been

closes #1694

Change-Id: I679fdd0ff9245e4413bc5a5ab40a70ea4f9ef7c0
(cherry picked from commit 88c0ffd49b)
(cherry picked from commit a06c0156ae)

Avoid trying to acquire a recursive lock by making sure the response is
always generated in a different thread.

Fixes #1656

Change-Id: I6c4c5bb52cb95a204823848bb427ab24f42dcccd
(cherry picked from commit 04ce204ef6)

The `encoder` is actually persistent and only freed when the output is
freed, so testing for its existence is not enough to determine whether
the output is open. The `fmtctx` can be used for that.

Change-Id: I2cc3f00a0e983fafd5915736089a0421385b6ce3
(cherry picked from commit 833c30d69e)

We're supposed to use the remote password for sending STUN error
responses (same as for sending STUN success responses), not the local
one.

Fixes a bug from 2015.

Closes #1626

Change-Id: I975178405dcd41661bdc5e0c1208295f9db70006
(cherry picked from commit 394ed2fc62)

While LWS explicitly allows usage of lws_callback_on_writable() from
other threads, for some reason there is no internal locking in place,
and so a concurrently running lws_service() can interfere with internal
structures, in particular if lws_service() is closing connections at the
same time as lws_callback_on_writable() is invoked.

The suggested approach of using lws_cancel_service() in combination with
the LWS_CALLBACK_EVENT_WAIT_CANCELLED callback and a user-kept queue is
not feasible, as we need to support LWS 2.x, which doesn't have
LWS_CALLBACK_EVENT_WAIT_CANCELLED.

Closes #1624

Change-Id: Ia3ddeda66fd553c87f99404e0816d97ecbd4cdfe
(cherry picked from commit 1457b34f65)

These functions now cannot fail and so returning a value is pointless.

Change-Id: I062449f30f05fb3efa4ba520004a13de3a0abd5a
(cherry picked from commit 26cc168f83)

Avoid calling lws_write() from threads other than the service thread, as
this might not be thread-safe. Instead store the values used for the
HTTP response headers in the websocket_output, then trigger a "writable"
callback, and finally do all the lws_write() calls from the service
thread.

Reported in #1624

Change-Id: Ifcb050193044e5543f750a12fb44f5e16d4c0a08
(cherry picked from commit b207d0c586)

... instead of explicit lock/unlock pairs to save some code lines.

Change-Id: Iece32fb201cd3b662038e91d98443e1dcfd04a63
(cherry picked from commit f293ca9a18)

Removes one level of indentation for prettier code. Functional no-op.

Change-Id: I5f5528944f144499540f34bc1f322d00c9454fa6
(cherry picked from commit cb9ec2abf9)

These are the entries the kernel will try to look for when userspace
tries to use the RTPENGINE support, but the module is called
xt_RTPENGINE so the kernel does not find it and thus cannot autoload
it.

The problem is that we have startup code that sets up iptables rules,
and will fail if the module has not yet been loaded. By adding these
aliases we are no longer concerned about the ordering, and can let the
kernel autoload the modules when they are needed.

Change-Id: I43a54af4e32adf755538c57df711da048c720030
(cherry picked from commit 2a6b2459f2)
(cherry picked from commit a294f9a99d)

This reverts commit b28794f853.

Change-Id: I1c61b939096fc935e47f83642653c3ac341cf553

lsb-base as of version 11.5 and as present in Debian/testing AKA
bookworm is a transitional package (depending on sysvinit-utils).
As of lintian >=2.116.0 a dependency on lsb-base is considered an error:

| E: ngcp-rtpengine-daemon: depends-on-obsolete-package Depends: lsb-base (>= 3.0-6)
| E: ngcp-rtpengine-recording-daemon: depends-on-obsolete-package Depends: lsb-base (>= 3.0-6)

Now having lintian 2.116.1 in Debian/testing AKA bookworm our package
builds fail because of this.

Since we still have init script support and references to
/lib/lsb/init-functions, let's depend on either sysvinit-utils
or lsb-base.

See related discussion on debian-devel mailing list:
https://lists.debian.org/debian-devel/2023/01/msg00149.html

Change-Id: Id3228425405e39904e52de8fdf00911539ac63bb
(cherry picked from commit e774bcb30f)

The SRTP decryption context is associated with the local socket. Use the
socket that a packet was actually received on for the decryption context
instead of using the one that it was expected to be received on.

Change-Id: Iddf400a440fc51b4afb370ec827f75e9626b2cfd
(cherry picked from commit a313d2b01b)

When a receiving socket doesn't match the socket we were expecting, make
sure that the receiving socket is actually one of the sockets we want to
use at this point before blindly switching the socket.

This fixes a race condition after a re-invite: A new set of sockets has
been opened, but an old/delayed RTP packet still arrives on one of the
old ports. In this case we don't want to switch the local socket.

Change-Id: I4e2b87ad608b1a9c6a0bb2eae5c305fd79be70d5
(cherry picked from commit 304a1b11ef)

The extension handling changed [0,1]. Fix compilation with iptables
1.8.8 [2].

[0] - https://git.netfilter.org/iptables/commit/?id=ef108943f69a6e20533d58823740d3f0534ea8ec
[1] - https://git.netfilter.org/iptables/commit/?id=6c689b639cf8e2aeced8685eca2915892d76ad86
[2] - openwrt/openwrt#9886

Signed-off-by: Nick Hainke <vincent@systemli.org>
(cherry picked from commit 2a6d5cd2cb)
(cherry picked from commit a39b0fb8bb)

Change-Id: Ifbfca3abacd6acba6d370820e36871c876b70d21

As Redis updates must be triggered with the call unlocked, use a
convenience wrapper function to unlock, update, unref.

fixes #1602

Change-Id: I67095f31fb605b6977c88d9e9b3db581dd71a0d9

The data in Redis must be updated after a successful publish/subscribe.

closes #1602

Change-Id: If39cbf04cf1c20e04b390b0b865c473a9acdb2ab
(cherry picked from commit cf6aa99dae)

Support fake bind() on non-INET sockets. This fixes the tests when
building against libwebsockets19 4.3.2-1.

Change-Id: I91e5271e8b0cd5a0fa10317bae059615b234926c
(cherry picked from commit 2f4ed358c0)

1) Read dtxb->start while the lock is held (not strictly necessary as
   the read should be atomic anyway)
2) Expect that dtxb->start can be larger than rtpe_now.tv

The latter can happen as `rtpe_now` in a timer thread is faked to be
exactly the time when the timer was supposed to run, and not the actual
current time, which means that a newly added packet can have a later
time stamp than the "now" the timer thread is using.

Change-Id: I48fd7f78af97c6d5b802e5151d69855a90f4032d

Usually supplemental RTP types (DTMF) are listed after the primary audio
codecs. In the case of the order being reversed, fix `single-codec` so
that it doesn't strip the actual audio codec that is listed after the
DTMF type.

Change-Id: I1b03b89e31bebf4de303b643dcf08d2ffb90ebaf

In some cases it's possible that some packets still arrive in userspace
immediately after a stream has been pushed to the kernel, for example if
some packets are already in the queue or if there is some processing
delay (e.g. writing to Redis). Allow for a short delay before counting a
stream as userspace if it has been pushed to the kernel.

Change-Id: I55a6e255868c8c2a9e93355a4aa2287f07b3748d
(cherry picked from commit 8a99171200)
(cherry picked from commit 0cbf96b187)

On bookworm and later, libasan reports a false positive in combination
with pthread_cleanup_push() (see [1]). Work around this by not using the
thread cleanup handler when running the asan build, and instead use a
shorter thread sleep time.

[1] https://gcc.gnu.org/bugzilla//show_bug.cgi?id=82109

Change-Id: Ieffdc0b13f470445f1f8e1d2448c6af6d8dd68e0
(cherry picked from commit c9a5714df7)

Keep the maximum time for a thread to sleep in a central place

Change-Id: Id4445f40d34648a2efbcbf17d67f2921c7dedf46
(cherry picked from commit 0c4fc1c31d)

Convenience macros to enable and disable thread cancellation

Change-Id: I1c588af83a4c6a45c60b60d941aa446b07e72978
(cherry picked from commit 08a05e76ec)

We want to disable thread cancellation here, not enable.

Change-Id: Ib0dd80c15af1e38252617d7cdaa1880f6c63485e
(cherry picked from commit 5188f24bec)

Legacy UDP/TCP control protocols don't provide information about RTP
payload types, therefore don't pretend that we know that this is RTP.
Setting the RTP flag without knowing the payload types has the undesired
side effect that unknown payload types (all of them) would not be
handled by the kernel module.

Change-Id: I5882f777a5912b912ec7c870f21c77aac8127600
(cherry picked from commit e811cd474d)

Instead of just leaving the transport protocol unset when we know we're
not supposed to be aware of the protocol, add a special entry to
suppress the pointless warning message.

Change-Id: I228c2f1652320627f974d9d7bcb0b1345adce2be
(cherry picked from commit 7ed04c3949)

Legacy protocols don't set sp->num_ports. Use a sensible default for
this case.

Probably a regression from 2d2d7665b

Change-Id: Idcbc477a68b6db70a91a5d082736ac642c50ab15
(cherry picked from commit 302f7d6457)

Move some code around to eliminate some redundant code paths.

Change-Id: I419728376aafe2561b5a2224b2f635d505936ee3
(cherry picked from commit 7a5069b194)

This is a regression from the overhaul of the stats bookkeeping code.

Change-Id: I9b7c2084fb20407e5a2a24fdf802b8fd6831dc75
(cherry picked from commit 9a3ced05ff)

frame->linesize has padding and alignment issues. Explicitly calculate
the buffer size instead.

Change-Id: Ib3fb6bcbd855ca9a3e9b01e131002de06984c292
(cherry picked from commit f0b0feeca7)

Change-Id: I7e103ba4eac16986ae53f0d99be7277ac51eb20a
(cherry picked from commit 5d17e5e6bd)

At least the recording daemon uses the linesize directly, so this needs
to be corrected after returning a frame from the resampler.

Change-Id: Ia940d8acbbee3fb2d6564474ecb93ae27422d8af
(cherry picked from commit 06efa83cb0)

Change-Id: I3f73b9d3482f018d8ae9748d59a161b8067cc294
(cherry picked from commit dc395d5752)

The packet must be decrypted first before RTP padding can be considered,
as the padding count is part of the encrypted payload as well.

Change-Id: I6aecff636efd420401856bb8110b3d784f989179
(cherry picked from commit 9e09cf3c40)

Older debhelpers don't support conditional installation locations.
Restore the previous approach of doing it through the rules file.

Change-Id: I427b44bed24bd9956c33c81cd28a75b262c46b68
(cherry picked from commit c53f213f9d)

Bullseye has debhelper 13, so nothing to do in the backports script

Change-Id: If9aa0f1bf25805b7c1913cee6d0feb3afd002c6d
(cherry picked from commit 6432a45228)

execute_after_dh_install is not used in the current rules file any more,
therefore no point in changing it for the backports

Change-Id: Icd375ba51530701d37dc8fc179424629cbd5218c
(cherry picked from commit 1ee1f14d0e)

closes #1539

Change-Id: I85b97dd316c2f6c4fab2c1fc879058eadff92305
(cherry picked from commit 1add191b84)