Starting with GNU make 4.4, build time have massively regressed
where before they would take 5m on amd64 now can take 2h40m. While this
seems clearly broken, the release notes are filled with notices for
breaking changes, and in particular the one for passing all make
variables down to the invoked programs executed via the «shell» GNU make
function, so it is not clear what is expected breakage and what is not.

This has been reported in Debian, but not yet upstream, and while it
seems like a clear regression, it's not clear what will be the upstream
take on it. For now apply workarounds that do not change semantics, and
which do not regress with older GNU make versions.

Use the GNU make «origin» function instead of «?=» which defaults to
defining a variable as a recursive one. Coerce already defined variables
into simple ones to avoid GNU make re-evaluating these variables for
each «shell» function invocation.

Ref: https://bugs.debian.org/1092051
Change-Id: I076fc05dd616918473a22e7e942fecfdc9851d47
(cherry picked from commit 887fb40f3f)
(cherry picked from commit 4c114ab9af)

Change-Id: I842b65571dc571c7c1a482dea62bb69d47700efd
(cherry picked from commit 928dd269b0)
(cherry picked from commit 415f9c2d85)

Change-Id: Ib881bfc3311a0d1e19a2d95bca671a607b678f08
(cherry picked from commit e234e11c98)
(cherry picked from commit 965f3590c0)

Change-Id: I1ed0a25b25e22f901d4811ff9e4ef9d8e087a4ad
(cherry picked from commit 7a58f4eb29)
(cherry picked from commit ee612d6f55)

If the receiver of a previously passthrough T.30 stream gets switched to
a generated PCM stream from a T.38 gateway, continue the sequencing of
the previous SSRC. Technically this is not necessary as the generated
PCM stream gets a new SSRC, but at least Asterisk seems to ignore this
and expect sequencing to continue, and will ignore PCM if the sequence
jump is too large.

Change-Id: Ia4656770db11f5fa1a1e9bf5bd71a0398deb1e00
(cherry picked from commit 18579227a9)
(cherry picked from commit 6422500ba3)

Just add the make target. Don't run it as part of the test suite as it's
quite extensive. Update the script a bit as well.

Change-Id: I192e90413bd7ffde842571324c816e4271367b42
(cherry picked from commit 0f55781a58)
(cherry picked from commit f8b8e7e80e)

Add a simple function that acts as an encryption callback to just update
the ext_seq (index) of the egress SSRC context. The kernel module
already does this, but the daemon only did it when SRTP was involved.
This now tracks egress packet indexes in all cases.

Change-Id: I9460744de55ead4b05aceb322fd8482442ff2b41
(cherry picked from commit 0da49000ba)
(cherry picked from commit 9279f30f75)

Change-Id: Ia43e1eb373c893df6693032a14eb631f16593094
(cherry picked from commit a19bed611c)
(cherry picked from commit edc98621c8)

Some components (the timer thread used by the codec handlers in
particular) may hold references to components owned by the codeclib (the
.so handles in particular). Move codeclib cleanup towards the end.

Change-Id: Ic581588c27b69c025576c14a69e999c9ca5d1597
(cherry picked from commit 43cc9cc06d)
(cherry picked from commit c747a9ad26)

Fixes a corner case that happens when trying to delete a call created with
ng offer and no-redis-update flag and for which no ng answer was received.
In such cases, one would receive warning messages from Redis
"ERR DB index is out of range".

What happens is that on call creation redis_hosted_db defaults to -1. This
value is changed when writing to Redis, but the writing is not done for a
ng offer with no-redis-update.

Kudos go to Pawel Kuzak.

Closes #1910

Change-Id: Iad19ec8ac69b169e6352662697b17eb23e6970fb
(cherry picked from commit bba9625b25)
(cherry picked from commit 1df2df383e)

Change-Id: I4b5536692d7076d8bcadd4ffbaf2312ecac5981e
(cherry picked from commit 4cdb8eaaca)
(cherry picked from commit 4223696ddb)

Just cover it with already existing lock
used below, but move upper.

Fixes Covery Scan detected defect:

*** CID 1621443:  Concurrent data access violations  (MISSING_LOCK)
/daemon/redis.c: 2232 in json_restore_call()
2226                            call_destroy(c);
2227                    release_closed_sockets();
2228                    if (must_release_pop) // avoid deadlock with redis_notify->lock below
2229                            redis_ports_release_pop(false);
2230                    must_release_pop = false;
2231
>>>     CID 1621443:  Concurrent data access violations  (MISSING_LOCK)
>>>     Accessing "rtpe_redis_write->db" without holding lock "redis.lock".
>>>     Elsewhere, "redis.db" is written to with "redis.lock" held 1 out of 1 times.
2232                    redis_select_db(rtpe_redis_write, rtpe_redis_write->db);
2233
2234                    mutex_lock(&rtpe_redis_write->lock);
2235                    redisCommandNR(rtpe_redis_write->ctx, "DEL " PB, PBSTR(callid));
2236                    mutex_unlock(&rtpe_redis_write->lock);
2237

Change-Id: Iff3425451f82218480dcc08f42ea7bddbd6f672f
(cherry picked from commit bebc6f8f31)
(cherry picked from commit 0a9b5fbdff)

Deleting a call can have the side effect of changing the active Redis DB
on the writing instance. Restore the correct DB afterwards if needed.

Fixes #1905

Change-Id: I12dae767ffa5d25703e024d2ec59aa21ba9da101
(cherry picked from commit fdabc9b59e)
(cherry picked from commit 6df71f2be7)

A call that gets created but then doesn't get initialised would have its
Redis DB left at zero. At destruction it would then try to switch to DB
zero. Fix this by using an appropriate initial value.

Closes #1905

Change-Id: I852e48c5a06b732b37d2ccd5c478de4760aacd4e
(cherry picked from commit add46f265a)
(cherry picked from commit 55f48a3bd6)

If keyspace notifications are used at all, the respective objects and
threads must be created during startup. This requires at least some
keyspace to be configured. To support usage without any keyspaces
initially (and add them during runtime), add a special case (set
keyspace to -1).

Convert all keyspace variables to signed ints. Ignore negative keyspace
numbers where appropriate. Support Redis endpoint addresses without
database number.

Fixes #1902

Change-Id: I45a3c87bc515f9b14e64ec1ec0906dde271b5f8d
(cherry picked from commit fb1ad3f0cf)
(cherry picked from commit bf60ce2744)

If keyspace notifications are not configured at all, bail with an error
when there is an attempt to add a new keyspace or remove one. We get a
segfault otherwise.

Closes #1902

Change-Id: Ie47cf5f7762792aabe38476739f0dcf9927787ce
(cherry picked from commit 6dbf098bc7)
(cherry picked from commit 96f5adaee1)

Change-Id: I949a715f1037df2c84c84565df8ea0fda14be191
(cherry picked from commit c07ab48457)
(cherry picked from commit 947b551781)

Avoids segfault is extra connection can't be established

Closes #1903

Change-Id: I6eb7315f6774015703c7ad036e08596f7f550d60
(cherry picked from commit 172f389395)
(cherry picked from commit 4ed9638e02)

Change-Id: I76f21d6c44f04e063cb57dd04f1f631dead0600a
(cherry picked from commit 3bbf4d94a1)
(cherry picked from commit 858ea8966d)

Change-Id: I55f1dad9480a991e512061f3ecaee00b865d9cad
(cherry picked from commit 3e0bd2e76f)
(cherry picked from commit 8125f29afa)

A matching payload type number in an answer might not be enough to
establish compatible codecs. Also check the format parameters. Reject
and ignore answer codecs that are not compatible.

Change-Id: I12a1287216886926ec4b3c704029c923f815b429
(cherry picked from commit 9c00f30475)
(cherry picked from commit 4860915441)

We don't parse these out and formats should be compatible.

Change-Id: Ie106591f3d12539eb1101793b50df9db97637625
(cherry picked from commit 68ad1dc8df)
(cherry picked from commit 008cb84e32)

Teach rtpengine to distinguish between G.729 with and without annex B,
which are incompatible to each other.

Change-Id: I09b66a097007ba3283546880f06f81b4f89e126d
(cherry picked from commit 7ab4009a0b)
(cherry picked from commit 55d76399f5)

Change-Id: I297199255b0d5204b0f978dc7306da8f2b6e6e34
(cherry picked from commit 9262cac855)
(cherry picked from commit d5947c47ad)

Make the year's value automatic.

Change-Id: I6b1ab23144c758aa047cdcbaf26ba86745d150c9
(cherry picked from commit 20d9db2966)
(cherry picked from commit d7e8810185)

Make entry tree simpler and give
links to commonly used things like
NG control protocol.

This simplifies usage of documentation.

Change-Id: I1283bf8a88c7c6e4ff7ab9451610bc6e224c0119
(cherry picked from commit 16b7200ed1)
(cherry picked from commit 38534f3dea)

Secondary titles have to be smaller:
- to embed it easier into the toctree of index file
- to have better readability for users (github,RTD)

Change-Id: If8f97f97b1d64b7593228eeda16c794e66453c27
(cherry picked from commit 2514d36129)
(cherry picked from commit 08e54d8152)

Remove the intro information from index,
because already mentioned in the overview.

Also change a greeting title.

Change-Id: I5c232fa033eac8e3097ad5adb351e8940a33a4ee
(cherry picked from commit a07b972000)
(cherry picked from commit f3bc68d7b4)

Reported in #1896

Change-Id: I58d09ef930c8fa55efa5592ff746a65270dea68b
(cherry picked from commit aca2433bbd)
(cherry picked from commit 1ca5c55808)

HTTP/WS init creates worker threads, which would be terminated by a fork
to background. Reverse the order.

Closes #1896
Possibly also relevant to #1895

Change-Id: I30b61e07ad3bed41b6b241e8943ed479277c1474
(cherry picked from commit dd04af1163)
(cherry picked from commit 12e22f2c8b)

Closes #1898

Change-Id: I585db2307f750abc18f9918451cab6c6c693965c
(cherry picked from commit f443bd8ce2)
(cherry picked from commit da90378b4b)

Change-Id: I2367ac1d490e5451d46629618ece513166faa2bd
(cherry picked from commit 7c7f627418)
(cherry picked from commit 4df2cf75b8)

Fixes regression from the sdp_create rework.

Change-Id: I875052a0e229bca529ea461d7cd3c1c068feebee
(cherry picked from commit 18e0db51a9)
(cherry picked from commit 10c83eca5a)

No-op.

Change-Id: Ie63441499544d39f9de2eb87c305b17a84a5ec8c
(cherry picked from commit e97aaca4a3)
(cherry picked from commit de6f1a30c1)

Helper function to append just one attribute

No-op.

Change-Id: I6076760250af4b7d5fe7f7490210e8f9c43f0d22
(cherry picked from commit 02a2dc1fac)
(cherry picked from commit 1394100237)

Change-Id: If0ebc38a30575346e2aaf08df7b125005cda0d80
(cherry picked from commit 6a7cd32beb)
(cherry picked from commit e3bf4987d8)

Change-Id: Id06c237482d25c6a517208dea29ca1c7542265e6
(cherry picked from commit ff7d2aa686)
(cherry picked from commit 2a67aacd99)

Some compilers seem to think that there is some uninitialised usage
here. Work around this.

Closes #1891

Change-Id: Ic97a4b589fd2a0c33418a209557b7ce29009c7bf
(cherry picked from commit 4b614d8ce0)

If recording-method is pcap, then proc is zero-initialized, so
meta_filepath is empty. This shows many logs such as:

[core] Failed to open recording metadata file '(null)' for writing: Bad address

Prevent them by returning earlier.

Closes #1889

Change-Id: Ifeb3038f9a5c0bd6a9b7dd92842dd61783b40263
(cherry picked from commit 759fd72dc6)

Fixes regression from the SDP printing rework.

Fixes #1885

(We should add tests for this...)

Change-Id: I2154cd61fbe4a0c9bf63a25128f038068acffa0a
(cherry picked from commit 1a1eaab50b)

Use an object with local storage for sdp_address instead of just setting
a pointer. This makes it possible to put a different address.

Change-Id: I92e69b6a9eba9d0caa3853b3dcb134951d76b145
(cherry picked from commit a733a8c83a)

- LTS mr11.5.1 doesn't build with system GCC 8.5 on EL8
- add a workaround for using GCC 13

Closes #1887
Closes #1886

Change-Id: Ib93942fae8f754c7673509ccb45e0d08569f23f0
Addresses: #1886
(cherry picked from commit 0e2033bbc7)

closes #1883

Change-Id: Ic364b8d2bdd0f50438b121571d86660b88b2945e
(cherry picked from commit 03ef7a737c)

These macros were used for development only and are not needed any more.
Their names collide with an upstream patch, making compilation fail on
kernels >= 6.12. Just remove these wrapper macros altogether.

Change-Id: I6e154be76bfcfb650581095b169ddd58e5f464a0
(cherry picked from commit 6b3f3b9698)