This commit: 6f0ad0db0f
introduced an improved behavior of the call deconstruction
when dealing with multiple forked legs. But it also
introduced a regression related to TPCC related calls.

This is because it takes into consideration existing
`->viabranches`, which is not efficient in certain cases.

Instead, we just have to ensure, whether there are
other monologues of the call object, which are not directly
"visible" for this branch being cancelled (so they are not directly
associated to that), but they might have own associations
present, which means the call mustn't be globally destoroyed.

Change-Id: I630f2d88ef3b557af3a95816fc2703daccaff374
(cherry picked from commit 0994ffbe75)
(cherry picked from commit ea78369855)

We're supposed to use the remote password for sending STUN error
responses (same as for sending STUN success responses), not the local
one.

Fixes a bug from 2015.

Closes #1626

Change-Id: I975178405dcd41661bdc5e0c1208295f9db70006
(cherry picked from commit 394ed2fc62)

While LWS explicitly allows usage of lws_callback_on_writable() from
other threads, for some reason there is no internal locking in place,
and so a concurrently running lws_service() can interfere with internal
structures, in particular if lws_service() is closing connections at the
same time as lws_callback_on_writable() is invoked.

The suggested approach of using lws_cancel_service() in combination with
the LWS_CALLBACK_EVENT_WAIT_CANCELLED callback and a user-kept queue is
not feasible, as we need to support LWS 2.x, which doesn't have
LWS_CALLBACK_EVENT_WAIT_CANCELLED.

Closes #1624

Change-Id: Ia3ddeda66fd553c87f99404e0816d97ecbd4cdfe
(cherry picked from commit 1457b34f65)

These functions now cannot fail and so returning a value is pointless.

Change-Id: I062449f30f05fb3efa4ba520004a13de3a0abd5a
(cherry picked from commit 26cc168f83)

Avoid calling lws_write() from threads other than the service thread, as
this might not be thread-safe. Instead store the values used for the
HTTP response headers in the websocket_output, then trigger a "writable"
callback, and finally do all the lws_write() calls from the service
thread.

Reported in #1624

Change-Id: Ifcb050193044e5543f750a12fb44f5e16d4c0a08
(cherry picked from commit b207d0c586)

... instead of explicit lock/unlock pairs to save some code lines.

Change-Id: Iece32fb201cd3b662038e91d98443e1dcfd04a63
(cherry picked from commit f293ca9a18)

Removes one level of indentation for prettier code. Functional no-op.

Change-Id: I5f5528944f144499540f34bc1f322d00c9454fa6
(cherry picked from commit cb9ec2abf9)

Don't change to a new port for sendonly streams as this causes problems
with NAT. A device receiving a sendonly SDP with a new port won't send
any RTP to the new port, leading to a closed (non existent) NAT mapping.

Change-Id: I2ea2163eb9f1203226bd781b53f421c790a86f0a
(cherry picked from commit 6d7603e064)

The old port latching logic was simply to use the last (newest)
allocated endpoint_map. This turned out to be wrong, because the last
used socket on the monologue could have been one that was allocated
earlier (and older endpoint_map), as it can happen during repeated
re-invites. Add a new function to actually look for the correct
endpoint_map, matching the currently used socket, to make sure the port
doesn't change.

Change-Id: Iae768fe48539264575aed67cbbb6b08ac745130f
(cherry picked from commit 3778d0f359)

Code refactor only, functional no-op

Change-Id: Ifb8354c6b7e2771de861d8d666a410eaf4d2755a
(cherry picked from commit 37d7664173)

These are the entries the kernel will try to look for when userspace
tries to use the RTPENGINE support, but the module is called
xt_RTPENGINE so the kernel does not find it and thus cannot autoload
it.

The problem is that we have startup code that sets up iptables rules,
and will fail if the module has not yet been loaded. By adding these
aliases we are no longer concerned about the ordering, and can let the
kernel autoload the modules when they are needed.

Change-Id: I43a54af4e32adf755538c57df711da048c720030
(cherry picked from commit 2a6b2459f2)
(cherry picked from commit e2edf36e85)

This reverts commit b28794f853.

Change-Id: I1c61b939096fc935e47f83642653c3ac341cf553

The SRTP decryption context is associated with the local socket. Use the
socket that a packet was actually received on for the decryption context
instead of using the one that it was expected to be received on.

Change-Id: Iddf400a440fc51b4afb370ec827f75e9626b2cfd
(cherry picked from commit a313d2b01b)

When a receiving socket doesn't match the socket we were expecting, make
sure that the receiving socket is actually one of the sockets we want to
use at this point before blindly switching the socket.

This fixes a race condition after a re-invite: A new set of sockets has
been opened, but an old/delayed RTP packet still arrives on one of the
old ports. In this case we don't want to switch the local socket.

Change-Id: I4e2b87ad608b1a9c6a0bb2eae5c305fd79be70d5
(cherry picked from commit d36fa163a1)

Support fake bind() on non-INET sockets. This fixes the tests when
building against libwebsockets19 4.3.2-1.

Change-Id: I91e5271e8b0cd5a0fa10317bae059615b234926c
(cherry picked from commit 2f4ed358c0)

1) Read dtxb->start while the lock is held (not strictly necessary as
   the read should be atomic anyway)
2) Expect that dtxb->start can be larger than rtpe_now.tv

The latter can happen as `rtpe_now` in a timer thread is faked to be
exactly the time when the timer was supposed to run, and not the actual
current time, which means that a newly added packet can have a later
time stamp than the "now" the timer thread is using.

Change-Id: I48fd7f78af97c6d5b802e5151d69855a90f4032d

Unmark a monologue that has been scheduled for deletion when it's
associated with another one, which happens during offer/answer.

Fixes a regression from 53dbef7e1 which removed this logic from
__monologue_unkernelize with re-adding it elsewhere.

Change-Id: I037162e91fec42631680f7767f58b172fd6e04db
(cherry picked from commit afb42551c4)

`call_get_monologue_new` is supposed to always return a full dialogue,
but an error in invocation (using a from-tag that doesn't belong to an
offer/answer) can lead to the second half being unset. Return an error
in this case.

Change-Id: I84b21ff5e5c0403fc07cae83fee206705ecff8b3
(cherry picked from commit c8171f7609)

During offer/answer, we remove existing subscriptions before
re-establishing the new set of subscriptions. But we must also remove
the subscriptions of previous subscribers in order to keep the lists of
subscriptions and subscribers correctly reciprocal.

Change-Id: I7d39fa59892159f41033ae6a40e7cb51d861b12e
(cherry picked from commit 41b0236915)

This is not used anywhere.

Change-Id: I0a1e722e5a8e60904182abf2d9c6cae60d4befbd
(cherry picked from commit 8d413f6018)

This serves no useful purpose any more.

Change-Id: Ife6cc85b0364536fb55baa0cc5da4e3126024ff6
(cherry picked from commit 8712e3b88e)

Use the new `associated_tags` table to determine which tags are
associated with which. Iterate the associations between tags in a
tree-like manner and do this at the moment the `delete` command is
received. Break up the `associated_tags` links at this time, and
determine which tags would be left dangling and mark all of these for
deletion. If no tags are left after this process, mark the entire call
for deletion.

The previous approach was cumbersome and prone to errors. Using tag
names and branch names to determine which tags are associated with which
is a pointless hurdle, and using a table of associations that is
explicitly kept for this purpose is a much cleaner approach. Also
postponing the decision about which tags to delete until the time the
deletion actually happens can lead to tags not being deleted, when they
really should be (e.g. A -> B, delete A, A -> C).

Change-Id: I03ae57d0a2117ecd721372c1a49468fc34dd630c
(cherry picked from commit 53dbef7e1a)

Keep track which tags (monologues) were created together as part of an
offer/answer exchange with a separate hash table, regardless of whether
these monologues actually have tagged names or are just nameless
branches.

Change-Id: I60aa114c8caf6ecdff4705e3399f60190d04dda6
(cherry picked from commit 6f0ad0db0f)

Usually supplemental RTP types (DTMF) are listed after the primary audio
codecs. In the case of the order being reversed, fix `single-codec` so
that it doesn't strip the actual audio codec that is listed after the
DTMF type.

Change-Id: I1b03b89e31bebf4de303b643dcf08d2ffb90ebaf

In some cases it's possible that some packets still arrive in userspace
immediately after a stream has been pushed to the kernel, for example if
some packets are already in the queue or if there is some processing
delay (e.g. writing to Redis). Allow for a short delay before counting a
stream as userspace if it has been pushed to the kernel.

Change-Id: I55a6e255868c8c2a9e93355a4aa2287f07b3748d
(cherry picked from commit 8a99171200)

Legacy UDP/TCP control protocols don't provide information about RTP
payload types, therefore don't pretend that we know that this is RTP.
Setting the RTP flag without knowing the payload types has the undesired
side effect that unknown payload types (all of them) would not be
handled by the kernel module.

Change-Id: I5882f777a5912b912ec7c870f21c77aac8127600
(cherry picked from commit e811cd474d)

Instead of just leaving the transport protocol unset when we know we're
not supposed to be aware of the protocol, add a special entry to
suppress the pointless warning message.

Change-Id: I228c2f1652320627f974d9d7bcb0b1345adce2be
(cherry picked from commit 7ed04c3949)

Legacy protocols don't set sp->num_ports. Use a sensible default for
this case.

Probably a regression from 2d2d7665b

Change-Id: Idcbc477a68b6db70a91a5d082736ac642c50ab15
(cherry picked from commit 302f7d6457)

Move some code around to eliminate some redundant code paths.

Change-Id: I419728376aafe2561b5a2224b2f635d505936ee3
(cherry picked from commit 7a5069b194)

This is a regression from the overhaul of the stats bookkeeping code.

Change-Id: I9b7c2084fb20407e5a2a24fdf802b8fd6831dc75
(cherry picked from commit 9a3ced05ff)

frame->linesize has padding and alignment issues. Explicitly calculate
the buffer size instead.

Change-Id: Ib3fb6bcbd855ca9a3e9b01e131002de06984c292
(cherry picked from commit f0b0feeca7)

Change-Id: I7e103ba4eac16986ae53f0d99be7277ac51eb20a

Instead of waiting for the garbage collector to clean up the SSRCs
objects, do it immediately when a delete is seen. This closes output
files and TLS connections more quickly.

Change-Id: I9a0a5be8194ba8597ff10e428d67d3a5654a2b62

At least the recording daemon uses the linesize directly, so this needs
to be corrected after returning a frame from the resampler.

Change-Id: Ia940d8acbbee3fb2d6564474ecb93ae27422d8af

Change-Id: I3f73b9d3482f018d8ae9748d59a161b8067cc294

The packet must be decrypted first before RTP padding can be considered,
as the padding count is part of the encrypted payload as well.

Change-Id: I6aecff636efd420401856bb8110b3d784f989179

Change-Id: I37c6e5ab09507a48ad91e4eab5ce275554076c72

Older debhelpers don't support conditional installation locations.
Restore the previous approach of doing it through the rules file.

Change-Id: I427b44bed24bd9956c33c81cd28a75b262c46b68

Bullseye has debhelper 13, so nothing to do in the backports script

Change-Id: If9aa0f1bf25805b7c1913cee6d0feb3afd002c6d