Re-move misleading log line to another place.
In the `sdp_manipulate_remove()` function:
- true - means remove
- false - means don't remove

Correct logging accordingly.

Change-Id: I3e0c08552a0192f3985da990b5f0c96cc31ece94

Convert existing sdp manipulation helpers
to work with arrays directly, independently from
which array is actually given.

Moreover, don't use the `G_N_ELEMENTS()`,
since we already have the `__MT_MAX`
as the size of the array, so we can directly use
that instead of relying on the G_N_ELEMENTS macro
(for array size checks).

Change-Id: I38e71dab30a467b933c213c8157fa06651ebaf04

Add a getter function for retrieval of top
most media from given media.

Currently existing getter for the top most
monologue's media subscription, just rename
so it makes more sense and is better to
differentiate:
`call_get_top_media_subscription()` -> `call_ml_get_top_ms()`

Change-Id: I5bf13b69b4d5f67cd6b53018b5a16d759542cd41

Hopefully this doesn't break other RHEL builds

Change-Id: I50e32bdafd2fef8a4791e745ccb90d80ff091fe1

Change-Id: I05937db7f8268c3a87aae8793a945a0009493252

closes #1870

Change-Id: I18a48d2e80872ccc8a0b52a13dbc23b82d1981cb

And add appropriate test

Change-Id: Ib9fb7914a7f22ecbf29866a56b1d4c65921f15a0

Change-Id: I566038f5fff96dbd5c1117d4016d56a4dfe72680

Update to use fixed-point math and to use the same helper function as
the G.107 formula. No-op.

Change-Id: I18ce12f98cda79f2c086425811c599370761afe7

Change-Id: Ia0e90d075e12fb3f0e595e1eb2fcace71b97b6ae

Add support for simplified G.107 formula, with math changed to
fixed-point. Retain legacy formula as an option for backwards
compatibility.

Change-Id: I999fc7de7be1407876c201c251538cea72b04008

Support different MOS formulas. Only "legacy" (existing formula) is
supported at this point.

Change-Id: I25846da993bf61a34f26a8384622b7a2a2bbcf06

So we can add more options

Change-Id: I0654fdb805d823057b9694a86bcf936a4a6e154f

Timing sensitive and long duration, so not enabled by default

Change-Id: Iade9e490bdb688b446f1ae1c9dc5642b79c513c5

Always create the offer/answer subscriptions during an offer/answer
exchange, making sure that no other offer/answer subscriptions can
exist.

Change-Id: I95e584c24e7ba74f2ead36d0c23976ef1f2e461c

Explicitly set log context to the outgoing socket when sending packets

Change-Id: Iae17951654b09b3c48de724aeded70cdb6ce7a40

Make sure stats are always added to the `delete` message.

Fixes stats being missing in case of `delete` without from-tag.

Change-Id: I635cc87b91d3e488696f33380b12dc68a24e51ad

The pcre2 API was changed from

	pcre2_substring_list_free(PCRE2_SPTR *)

to

	pcre2_substring_list_free(PCRE2_UCHAR **)

in 10.43. The difference is a `const` qualifier. Work around this.

Closes #1869

Change-Id: Ib3dd3003352f6c3155bb47d69ecb7a1b02f4647a

Change-Id: I2fafa4055be06b22671abf789ea51cf6409c5e1b

`sdp_address` is always non-NULL

Change-Id: I53067e1b46b8ce0843b872d2feb02f426adeb579
Warned-by: Coverity

Change-Id: I516972d85a26d68b9f9c2a9613294a02448391b6

Change-Id: Ifcd7cd0d2677f1c62f20da7b4529da1c2a7e68e5

Fix the math in the sequencer code to determine ROC and extended
sequence number. This has become significant as the sequence numbers are
written into shared memory space.

Change-Id: I9e519a29a3822d02f7c389920ee0909b48828525

We use int or unsigned int everywhere, except in a few leftover places.
Unify to (unsigned) int.

Change-Id: I0896b2f177957c17b30a3d0cb6b3fb2beb4bd684

Allow usage of `key=[ something ]` in rtpp_flags

One test is affected

Change-Id: Ib3d68f298d2e0cd02c74bf2c7d3d02b055223bc4

These functions expect a `rtpp_pos` argument, and while `str` is
compatible through the union, it lacks the second member of the struct,
which ends up uninitialised. Use the correct type through temporary
objects instead.

Change-Id: I0c553bdbb31c351346746b6072f2d424113bac5a

`next_exp_seq` must also be protected by the mutex.

Change-Id: I2fb223d9b29c891e45430887bfb3549d1a85b653
Warned-by: Coverity

`local_ep` can end up as NULL. Don't try to send to Homer without it.

Change-Id: Ie4055034f60749f454feeb674cc080c8089ac913
Warned-by: Coverity

Bit fields have been changed to unsigned. Adjust code accordingly.

Warned-by: Coverity
Change-Id: I5e37361f7381a5e6fa7dff557ff3558bf62c2506

Change-Id: I1d31e65d4d1a3106844c4b069353ca6b6126fd3a
Warned-by: Coverity

Change-Id: I478241ffe234c01d2b34ffb37837417fafcdb49f
Warned-by: Coverity

Change-Id: If5f67895ec3b568d52bfef513383405e45b0169d

Don't proceed with the trickle updates in
case the required room, hence a call
hasn't been found.

Fixes Coverity Scan defect:

*** CID 1600057:  Null pointer dereferences  (NULL_RETURNS)
/daemon/janus.c: 1679 in janus_trickle()
1673            // ufrag can be given in-line or separately
1674            sp->ice_ufrag = cand->ufrag;
1675            if (!sp->ice_ufrag.len && ufrag)
1676                    bencode_strdup_str(&ngbuf->buffer, &sp->ice_ufrag, ufrag);
1677
1678            // finally do the update
>>>     CID 1600057:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "call" when calling "trickle_ice_update".
1679            trickle_ice_update(ngbuf, call, &flags, &streams);
1680
1681            return NULL;
1682     }
1683
1684

Change-Id: Ib2e293c2f99e914e3d02fe43d08160ec30892ae4

0f9dd5def2 introduced this check for `source_media`
which was only in use by `sdp_replace()` functionality.

`sdp_create()`'s one never really reaches it, even
in older implementation where `handle_sdp_media_attributes()`
was used.

So for now it has no use, just remove it.

Fixes:

*** CID 1600058:  Control flow issues  (DEADCODE)
/daemon/sdp.c: 2690 in print_sdp_media_section()
2684
2685            /* print sendrecv */
2686            if (!flags->original_sendrecv)
2687                    append_attr_to_gstring(s, sdp_get_sendrecv(media), NULL, flags,
2688                                    media->type_id);
2689            else if (source_media)
>>>     CID 1600058:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "append_attr_to_gstring(s, s...".
2690                    append_attr_to_gstring(s, sdp_get_sendrecv(source_media), NULL, flags,
2691                                    media->type_id);
2692
2693            ps_rtcp = print_rtcp(s, media, rtp_ps_link, flags);
2694
2695            if (proto_is_rtp(media->protocol)) {

** CID 1600057:  Null pointer dereferences  (NULL_RETURNS)

Change-Id: I2d2ffbb0c9ecc0fae8890367754fbbd6e79e9c21

Fixes:

*** CID 1600059:  Null pointer dereferences  (FORWARD_NULL)
/include/call.h: 919 in call_str_cpy()
913             return out;
914     }
915     INLINE str call_str_cpy_len(const char *in, size_t len) {
916             return call_str_cpy_fn(in, len, NULL);
917     }
918     INLINE str call_str_cpy(const str *in) {
>>>     CID 1600059:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "in".
919             return call_str_cpy_fn(in ? in->s : NULL, in ? in->len : 0, in->dup);
920     }
921     INLINE str call_str_cpy_c(const char *in) {
922             return call_str_cpy_len(in, in ? strlen(in) : 0);
923     }
924     INLINE str *call_str_dup(const str *in) {

Change-Id: I975d5bd420edc3605e59e16313dce488eff46e0c

Not needed any more. All strings reside in the call's memory arena, and
SDP rewriting isn't a thing any more.

Change-Id: I594b85fe26f44fa25312eb97fb65de238fc18920

Avoids allocating and duplicating the string. Should be safe as all
strings that use it are allocated in read-write memory.

Requires changing some struct members to non-const.

Change-Id: Idc81a84a1454898c76d8514666c385307043bb6f

If a string is already stored within the call's memory arena, skip
duplicating the string content when making a copy, and simply return the
same pointer.

Change-Id: I50107d87b2625234a395da21e1e4551585966a60

Use provided macros for initrialise str objects everywhere instead of
manually setting .s and .len. This allows for flexibility to extend str
objects.

Change-Id: I5ebca0bc82b348301c2c8e94b974c7acbf249b82

Avoids duplicate expansion of macro arguments.

Change-Id: I3485313f043fd0284337f94bea31955ccf151fca

Convenience wrapper for &STR()

This is useful so that STR() and STR_DUP() can be extended to avoid
duplicate expansion of its macro arguments.

Change-Id: Ieae170807c11b0cdd8b52fac9bab98dccdc2b951

Use the existing `str` primitives instead of doing explicit pointer
manipulations.

Change-Id: I9ce1df77c20a1ba8f394b3221cc2a284b9045c40

Instead of keeping one global hash/list of all received ICE fragments,
indexed by string call ID and from-tag, move the hash/list of ICE
fragments into the call object, now indxed only by the from-tag.

This requires a call object to exist before an ICE fragment can be
stored. Change the order of operations to always create a call object
first, then parse the SDP, then check for ICE fragment processing. The
determining factor now is only whether the monologue exists.

Duplicate the raw SDP into the call's memory arena instead of onto the
heap.

ICE fragments now don't need to store the pre-parsed SDP any more, and
the trickle ICE handling code is guaranteed to always have the fully
parsed SDP information.

Strings for fragment indexes can now be allocated from the call's memory
arena.

Obsolete the extra thread used to delete old ICE fragments. This is now
done in-line with regular call timeout processing.

Change-Id: I7acbc4c52666c4cdf1c02324bf33cf0bfcb4f0d0

If we remove a session that is not the session we're looking for
(re-used session ID after a removal race), we must return the incorrect
session to the hash table.

Change-Id: Iab73e1994251e5be766406b4e537a954b0e81f07

Release object reference when key is removed. Only relevant at shutdown.

Change-Id: Idc18890bb34d7e584dc5b4816553c759c3c663e2

Checks end-of-candidates.

Change-Id: I69e130795333876db7b3ea2eb5b4094fd532fbd5

Flag the media via stream params, when it's
trickle or non-trickle offer/answer, and,
unflag it always only when it's non-trickle.

Change-Id: Ia85ce5792684a4121e224aff1a8e941e061fe5a8

Change-Id: I1e4bd5ae2e3eef383733616c21b3669c8ab5ab94

The OTHER type attributes are not used outside of sdp.c. Move the
definitions into the appropriate scope.

Rename fields to be consistent with other attributes.

No-op.

Change-Id: Id92f2df2f475db92ee5ae1f3474191266d6d196d

Purely semantic change

Change-Id: I737a59c6031bdb05f2166ac78a490e2181d03743