The pcre2 API was changed from

	pcre2_substring_list_free(PCRE2_SPTR *)

to

	pcre2_substring_list_free(PCRE2_UCHAR **)

in 10.43. The difference is a `const` qualifier. Work around this.

Closes #1869

Change-Id: Ib3dd3003352f6c3155bb47d69ecb7a1b02f4647a

Change-Id: I2fafa4055be06b22671abf789ea51cf6409c5e1b

`sdp_address` is always non-NULL

Change-Id: I53067e1b46b8ce0843b872d2feb02f426adeb579
Warned-by: Coverity

Change-Id: I516972d85a26d68b9f9c2a9613294a02448391b6

Change-Id: Ifcd7cd0d2677f1c62f20da7b4529da1c2a7e68e5

Fix the math in the sequencer code to determine ROC and extended
sequence number. This has become significant as the sequence numbers are
written into shared memory space.

Change-Id: I9e519a29a3822d02f7c389920ee0909b48828525

We use int or unsigned int everywhere, except in a few leftover places.
Unify to (unsigned) int.

Change-Id: I0896b2f177957c17b30a3d0cb6b3fb2beb4bd684

Allow usage of `key=[ something ]` in rtpp_flags

One test is affected

Change-Id: Ib3d68f298d2e0cd02c74bf2c7d3d02b055223bc4

These functions expect a `rtpp_pos` argument, and while `str` is
compatible through the union, it lacks the second member of the struct,
which ends up uninitialised. Use the correct type through temporary
objects instead.

Change-Id: I0c553bdbb31c351346746b6072f2d424113bac5a

`next_exp_seq` must also be protected by the mutex.

Change-Id: I2fb223d9b29c891e45430887bfb3549d1a85b653
Warned-by: Coverity

`local_ep` can end up as NULL. Don't try to send to Homer without it.

Change-Id: Ie4055034f60749f454feeb674cc080c8089ac913
Warned-by: Coverity

Bit fields have been changed to unsigned. Adjust code accordingly.

Warned-by: Coverity
Change-Id: I5e37361f7381a5e6fa7dff557ff3558bf62c2506

Change-Id: I1d31e65d4d1a3106844c4b069353ca6b6126fd3a
Warned-by: Coverity

Change-Id: I478241ffe234c01d2b34ffb37837417fafcdb49f
Warned-by: Coverity

Change-Id: If5f67895ec3b568d52bfef513383405e45b0169d

Don't proceed with the trickle updates in
case the required room, hence a call
hasn't been found.

Fixes Coverity Scan defect:

*** CID 1600057:  Null pointer dereferences  (NULL_RETURNS)
/daemon/janus.c: 1679 in janus_trickle()
1673            // ufrag can be given in-line or separately
1674            sp->ice_ufrag = cand->ufrag;
1675            if (!sp->ice_ufrag.len && ufrag)
1676                    bencode_strdup_str(&ngbuf->buffer, &sp->ice_ufrag, ufrag);
1677
1678            // finally do the update
>>>     CID 1600057:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "call" when calling "trickle_ice_update".
1679            trickle_ice_update(ngbuf, call, &flags, &streams);
1680
1681            return NULL;
1682     }
1683
1684

Change-Id: Ib2e293c2f99e914e3d02fe43d08160ec30892ae4

0f9dd5def2 introduced this check for `source_media`
which was only in use by `sdp_replace()` functionality.

`sdp_create()`'s one never really reaches it, even
in older implementation where `handle_sdp_media_attributes()`
was used.

So for now it has no use, just remove it.

Fixes:

*** CID 1600058:  Control flow issues  (DEADCODE)
/daemon/sdp.c: 2690 in print_sdp_media_section()
2684
2685            /* print sendrecv */
2686            if (!flags->original_sendrecv)
2687                    append_attr_to_gstring(s, sdp_get_sendrecv(media), NULL, flags,
2688                                    media->type_id);
2689            else if (source_media)
>>>     CID 1600058:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "append_attr_to_gstring(s, s...".
2690                    append_attr_to_gstring(s, sdp_get_sendrecv(source_media), NULL, flags,
2691                                    media->type_id);
2692
2693            ps_rtcp = print_rtcp(s, media, rtp_ps_link, flags);
2694
2695            if (proto_is_rtp(media->protocol)) {

** CID 1600057:  Null pointer dereferences  (NULL_RETURNS)

Change-Id: I2d2ffbb0c9ecc0fae8890367754fbbd6e79e9c21

Fixes:

*** CID 1600059:  Null pointer dereferences  (FORWARD_NULL)
/include/call.h: 919 in call_str_cpy()
913             return out;
914     }
915     INLINE str call_str_cpy_len(const char *in, size_t len) {
916             return call_str_cpy_fn(in, len, NULL);
917     }
918     INLINE str call_str_cpy(const str *in) {
>>>     CID 1600059:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "in".
919             return call_str_cpy_fn(in ? in->s : NULL, in ? in->len : 0, in->dup);
920     }
921     INLINE str call_str_cpy_c(const char *in) {
922             return call_str_cpy_len(in, in ? strlen(in) : 0);
923     }
924     INLINE str *call_str_dup(const str *in) {

Change-Id: I975d5bd420edc3605e59e16313dce488eff46e0c

Not needed any more. All strings reside in the call's memory arena, and
SDP rewriting isn't a thing any more.

Change-Id: I594b85fe26f44fa25312eb97fb65de238fc18920

Avoids allocating and duplicating the string. Should be safe as all
strings that use it are allocated in read-write memory.

Requires changing some struct members to non-const.

Change-Id: Idc81a84a1454898c76d8514666c385307043bb6f

If a string is already stored within the call's memory arena, skip
duplicating the string content when making a copy, and simply return the
same pointer.

Change-Id: I50107d87b2625234a395da21e1e4551585966a60

Use provided macros for initrialise str objects everywhere instead of
manually setting .s and .len. This allows for flexibility to extend str
objects.

Change-Id: I5ebca0bc82b348301c2c8e94b974c7acbf249b82

Avoids duplicate expansion of macro arguments.

Change-Id: I3485313f043fd0284337f94bea31955ccf151fca

Convenience wrapper for &STR()

This is useful so that STR() and STR_DUP() can be extended to avoid
duplicate expansion of its macro arguments.

Change-Id: Ieae170807c11b0cdd8b52fac9bab98dccdc2b951

Use the existing `str` primitives instead of doing explicit pointer
manipulations.

Change-Id: I9ce1df77c20a1ba8f394b3221cc2a284b9045c40

Instead of keeping one global hash/list of all received ICE fragments,
indexed by string call ID and from-tag, move the hash/list of ICE
fragments into the call object, now indxed only by the from-tag.

This requires a call object to exist before an ICE fragment can be
stored. Change the order of operations to always create a call object
first, then parse the SDP, then check for ICE fragment processing. The
determining factor now is only whether the monologue exists.

Duplicate the raw SDP into the call's memory arena instead of onto the
heap.

ICE fragments now don't need to store the pre-parsed SDP any more, and
the trickle ICE handling code is guaranteed to always have the fully
parsed SDP information.

Strings for fragment indexes can now be allocated from the call's memory
arena.

Obsolete the extra thread used to delete old ICE fragments. This is now
done in-line with regular call timeout processing.

Change-Id: I7acbc4c52666c4cdf1c02324bf33cf0bfcb4f0d0

If we remove a session that is not the session we're looking for
(re-used session ID after a removal race), we must return the incorrect
session to the hash table.

Change-Id: Iab73e1994251e5be766406b4e537a954b0e81f07

Release object reference when key is removed. Only relevant at shutdown.

Change-Id: Idc18890bb34d7e584dc5b4816553c759c3c663e2

Checks end-of-candidates.

Change-Id: I69e130795333876db7b3ea2eb5b4094fd532fbd5

Flag the media via stream params, when it's
trickle or non-trickle offer/answer, and,
unflag it always only when it's non-trickle.

Change-Id: Ia85ce5792684a4121e224aff1a8e941e061fe5a8

Change-Id: I1e4bd5ae2e3eef383733616c21b3669c8ab5ab94

The OTHER type attributes are not used outside of sdp.c. Move the
definitions into the appropriate scope.

Rename fields to be consistent with other attributes.

No-op.

Change-Id: Id92f2df2f475db92ee5ae1f3474191266d6d196d

Purely semantic change

Change-Id: I737a59c6031bdb05f2166ac78a490e2181d03743

Change-Id: Iebfc00d38593db37139767c8305b5a120633ce11

So we can attach other attributes to the strings

Change-Id: I3e6090c8557879efb40ddeb6635ed4b10e742112

This is needed to handle non-null terminated strings

Change-Id: I83ef0af0b8a3471fadf8d3e53867f53636b11986

Change-Id: I338f1a90890701fe202179f8079f564a50dce5f0

We should be ok.

Change-Id: Ibdf81ace9c6c62a9b58fcb56d3c80f7e0bcf62ee

Use a BIO WRITE callback instead of BIO_read'ing from the BIO after each
operation. This is a more direct way to intercept data that needs to be
sent out.

Implement MTU-related BIO callbacks.

Deduct the assumed IP MTU overhead from the configured MTU during
startup.

Unlike the previous code, this does not necessarily send DTLS from the
same socket that received a message, nor to the same address that sent
one, and instead always uses the selected_sfd and ->endpoint. This may
or may not be a regression.

Closes #1806

Change-Id: I4d4456df3f378d00782cbfa64afdb2a038217e6c

Change-Id: I241ad19cea7db2eda28968ea9746f42dbfbeea59

Refactor inactive streams handling (non-accepted media) so,
that they get also labels being printed.

Change-Id: I6627aba77a5f391f797762202eb4f0977bc0fc4a

Print the `c=` attribute before all other attributes.

Additionally: fix tests accordingly.

Change-Id: I338a84d79ed9d7045bcfd0f07a40a16b986d2fcc

Just remove them and re-write commentaries so,
that they make sense taking into account we don't use
the chopper anymore.

Change-Id: I60254061d6d2a7c7b1b181c288144e27b8d2c6b5

Because currently it is directly handled by the
`generic_append_attr_to_gstring()` implementation, a couple
of functions (previously used by the sdp_replace)
are from now on obsolete and not needed anymore:
- `sdp_manipulations_subst_attr()`
- `sdp_manipulate_remove_attr()`

Just remove them.

Change-Id: Ia33218fa4c144812ff3265abafb62fd7f50f6955

Deprecate the chopper and related functionality:
- copy_up_to_end_of()
- copy_up_to()
- copy_up_to_ptr()
- copy_remainder()
- skip_over()
- chopper_append_str()
- chopper_append_c()
- chopper_append()
- chopper_replace
- chopper_append_printf()
- sdp_chopper_new()
- sdp_chopper_destroy()
- sdp_chopper_destroy_ret()

Deprecate the chopper structure itself:
- `struct sdp_chopper`

Deprecate other usages of this struct:
- `ng_buffer->chopper`

Change-Id: I3bff8aaf24c6513ccd9fb3806474d8edac6eb866

Since not in use anymore just deprecate it.

Change-Id: I33ec44fd7d1a333e192b222fd2e1c7a3e7b17e36

Instead of returning a pointer to ps, just return void,
because previously used pointer (by sdp_replace) is
not used by any other function.

Change-Id: If2e211b98ab801061f40210b571804ff8184124f

Move content of the `handle_sdp_media_attributes()` function
into the `print_sdp_media_section()` function. With all required
refactoring. No functional change.

Change-Id: Ia1e5019165a4ea281f17ac8df712701eea772155

From now on inactive medias are handled in advance
by `handle_sdp_media_attributes()`, so all non-accepted medias
are alsways caught here and never deal with
`print_sdp_media_section()`.

Hence, deprecate `is_active` bool for it and refactor the
implementation of `print_sdp_media_section()`.

Change-Id: Ief7b1de204681373660c74c71c972b289216015c

Not required anymore, since this function is only
in use by the sdp_create one.

Change-Id: I56d016d99f6d994805dc3fe7fdafd7c0d729a466